Skip to content

New edition of process_pr - #2626

Open
iarspider wants to merge 25 commits into
masterfrom
sign-hashes-not-commits
Open

New edition of process_pr#2626
iarspider wants to merge 25 commits into
masterfrom
sign-hashes-not-commits

Conversation

@iarspider

@iarspider iarspider commented Nov 28, 2025

Copy link
Copy Markdown
Contributor


@smuzaffar as discussed today. I have put new code into new file (process_pr_v2.py), will replace old process_pr before merging.

It doesn't yet do everything - for example, it won't detect when tests are complete, I will implement it later.

We can also use this opportunity to implement our own handling of commit statuses (I have a draft cgi handler for this) that we should discuss offline.

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

3 similar comments
@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@cmsbuild

cmsbuild commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@cmsbuild

cmsbuild commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@iarspider
iarspider force-pushed the sign-hashes-not-commits branch from e539998 to 5fc68a2 Compare December 3, 2025 11:45
@cmsbuild

cmsbuild commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@iarspider
iarspider force-pushed the sign-hashes-not-commits branch from 8e05b86 to c964451 Compare December 4, 2025 09:59
@cmsbuild

cmsbuild commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

4 similar comments
@cmsbuild

cmsbuild commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@cmsbuild

cmsbuild commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@cmsbuild

cmsbuild commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@cmsbuild

cmsbuild commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

Pull request #2626 was updated.

@smuzaffar

Copy link
Copy Markdown
Contributor

FYI @iarspider #2626 (comment) (new bot is keep on triggering code-checks for cms-sw/cmssw#49771 )

@smuzaffar

smuzaffar commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

For now I have added <cmsbot></cmsbot> in the cms-sw/cmssw#49771 PR description so that bot does not run for it (and avoid resursive code-checks)

@iarspider

Copy link
Copy Markdown
Contributor Author

Checking.

@iarspider

Copy link
Copy Markdown
Contributor Author

Forward-ported #2806.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants