Skip to content

fix(settings): give the Layout tab its own title instead of Appearance's #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucletoffe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(settings): give the Layout tab its own title instead of Appearance's #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion components/settings/layout-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,12 @@ function MailLayoutPreview({
}

export function LayoutSettings() {
// Every item on this page is keyed under `settings.appearance` for historical
// reasons, so `t` stays on that namespace. Only the section header moves to
// `settings.layout` — otherwise this tab renders the exact same title and
// description as the Appearance tab and the two become indistinguishable.
const t = useTranslations('settings.appearance');
const tLayout = useTranslations('settings.layout');
const tEmail = useTranslations('settings.email_behavior');
const { toolbarPosition, showToolbarLabels, hideAccountSwitcher, showRailAccountList, enableUnifiedMailbox, includeGroupInUnified, unifiedCrossAccount, allMailFolderIds, enableCrossUnreadView, enableCrossStarredView, enableCrossAllView, colorfulSidebarIcons, tintListRowsByTag, showFolderTotalCount, faviconUnreadBadge, mailLayout, proInterface, updateSetting } = useSettingsStore();
const { isSettingLocked, isSettingHidden, isFeatureEnabled } = usePolicyStore();
Expand Down Expand Up @@ -167,7 +172,7 @@ export function LayoutSettings() {
: null;

return (
<SettingsSection title={t('title')} description={t('description')}>
<SettingsSection title={tLayout('title')} description={tLayout('description')}>
{!isSettingHidden('mailLayout') && (
<SettingItem label={tEmail('mail_layout.label')} description={tEmail('mail_layout.description')} locked={isSettingLocked('mailLayout')}>
<div className="w-[22rem] max-w-full">
Expand Down
4 changes: 4 additions & 0 deletions locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,10 @@
"description": "Show an All mail entry in the Unified Mailbox listing all mail across the selected folders."
}
},
"layout": {
"title": "Layout",
"description": "Arrange the reading pane, toolbar, sidebar and unified mailbox"
},
"keywords": {
"title": "Email Tags",
"description": "Define tags to organize your emails. These are stored as JMAP keywords on the server.",
Expand Down