fix(settings): give the Layout tab its own title instead of Appearance's - #846
Open
lucletoffe wants to merge 1 commit into
Open
fix(settings): give the Layout tab its own title instead of Appearance's#846lucletoffe wants to merge 1 commit into
lucletoffe wants to merge 1 commit into
Conversation
Settings → Layout renders the header "Appearance / Customize the look and feel of your webmail" — byte for byte what Settings → Appearance renders. `LayoutSettings` reads every string from the `settings.appearance` namespace, including the section title, so the two tabs are indistinguishable once open. Concretely: a user looking for "Unified Mailbox / All mail" lands on Appearance, reads a page titled "Appearance", finds theme, density and avatar toggles, and concludes the setting does not exist — while it sits one tab below under an identical heading. Only the section header moves to a new `settings.layout` namespace; the items keep their `settings.appearance` keys, so no existing translation is invalidated. Locales without `settings.layout` fall back to English through `mergeMessages`, so nothing renders a raw key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Settings → Layout renders the header
Appearance/ Customize the look and feel of your webmail — byte for byte what Settings → Appearance renders.LayoutSettingsreads every string from thesettings.appearancenamespace, including the section title, so once you are on the page there is nothing telling the two tabs apart.Why it matters
Real case that prompted this: looking for Unified Mailbox → All mail (to make search span every folder). You open Appearance, the page says "Appearance", you find theme / font size / density / avatar toggles, and you conclude the setting does not exist. It is one tab below, under an identical heading.
The sidebar highlight is the only cue, and it is easy to miss on a wide screen where the two tabs sit next to each other under the same
APPEARANCEgroup.Fix
Only the section header moves to a new
settings.layoutnamespace:Deliberately minimal:
settings.appearancekey, so no existing translation in any of the 30+ locales is invalidated;en/common.jsongains the two new strings — locales withoutsettings.layoutfall back to English viamergeMessages, so nothing renders a raw key likesettings.layout.title.Checks
npx tsc --noEmit— cleannpx eslint components/settings/layout-settings.tsx— cleannpx vitest runon the neighbouring settings/store suites — 12 passed