Skip to content

Point two comments at functions that exist #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 1 commit into from
Aug 4, 2026
Merged

Point two comments at functions that exist #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/commands/accountwide.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,17 @@ func accountWideCapNotice(capped bool, meta basecamp.ListMeta, count int, plural
// algorithm untouched; the number of requests it takes is a property of the
// result, not of the filter.
//
// Project-scoped --assignee is a different animal — see the note on
// filterTodosByAssignees.
// Project-scoped --assignee is a different animal: that endpoint has no
// assignee parameter, so the flag is applied client-side over an unlimited
// fetch. See the note in listTodosInList (internal/commands/todos.go).

// dueFilterValues are the tokens --due accepts. These are categories, not
// dates: internal/dateparse is deliberately not involved, since "overdue" is
// not a date and "with" is not a date range.
var dueFilterValues = []string{"with", "without", "overdue"}

// rejectEmptyTaskFilterValues refuses an explicitly empty --due or --assignee.
// validateTaskFilterValues refuses an explicitly empty --due or --assignee, and
// an unknown --due token.
//
// Every other check in this file tests the flag's *value*, which makes `--due=`
// indistinguishable from never passing --due: the project-scoped guard stops
Expand Down
Loading