Point two comments at functions that exist - #614
Merged
Conversation
accountwide.go referred readers to filterTodosByAssignees, which is not a function in this repository — the project-scoped assignee note lives in listTodosInList. Point there, and say what the note actually says so the reference is useful without following it. The second is mine from #612: I renamed rejectEmptyTaskFilterValues to validateTaskFilterValues when it took on the --due token check, and left its doc comment naming the old function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only. Both were flagged by Copilot on #612 and judged real but
non-blocking, so I did not move that PR's reviewed head for them. Follow-up now
that #612 has merged.
filterTodosByAssigneesdoes not exist in this repository. Theproject-scoped assignee note it points at lives in
listTodosInList(
internal/commands/todos.go). Redirected there, and the reference now stateswhat the note says — the endpoint has no assignee parameter, so the flag is
applied client-side over an unlimited fetch — so it is useful without following
it.
The second is mine, from #612. I renamed
rejectEmptyTaskFilterValuestovalidateTaskFilterValueswhen it took on the--duetoken check, and left itsdoc comment naming the old function. The comment also now mentions the token
check it gained.
bin/ciexit 0. No behaviour change.Summary by cubic
Fix two doc comments: project-scoped
--assigneenow points tolistTodosInListwith a note on client-side filtering, andvalidateTaskFilterValuesmentions the--duetoken check. No behavior change.Written for commit b855095. Summary will update on new commits.