Skip to content

Fix OpenSearch username/password env fallback in examples #39111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

Fix OpenSearch username/password env fallback in examples #39111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/notebooks/beam-ml/rag_usecase/opensearch_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ def __init__(self,
"""
self.host = host
self.port = port
self.username = username | os.getenv("OPENSEARCH_USERNAME")
self.password = password | os.getenv("OPENSEARCH_PASSWORD")
self.username = username or os.getenv("OPENSEARCH_USERNAME")
self.password = password or os.getenv("OPENSEARCH_PASSWORD")
self._batch_size = batch_size

if not self.username or not self.password:
Expand Down Expand Up @@ -247,8 +247,8 @@ def __init__(self,
"""
self.host = host
self.port = port
self.username = username | os.getenv("OPENSEARCH_USERNAME")
self.password = password | os.getenv("OPENSEARCH_PASSWORD")
self.username = username or os.getenv("OPENSEARCH_USERNAME")
self.password = password or os.getenv("OPENSEARCH_PASSWORD")
self.batch_size = batch_size
self.embedded_columns = embedded_columns

Expand Down
4 changes: 2 additions & 2 deletions examples/notebooks/beam-ml/rag_usecase/opensearch_enrichment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ def __init__(
"""
self.opensearch_host = opensearch_host
self.opensearch_port = opensearch_port
self.username = username | os.getenv("OPENSEARCH_USERNAME")
self.password = password | os.getenv("OPENSEARCH_PASSWORD")
self.username = username or os.getenv("OPENSEARCH_USERNAME")
self.password = password or os.getenv("OPENSEARCH_PASSWORD")
self.index_name = index_name
self.vector_field = vector_field
self.k = k
Expand Down
Loading