Fix OpenSearch username/password env fallback in examples#39111
Fix OpenSearch username/password env fallback in examples#39111fallintoplace wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a logic error in the OpenSearch connector and enrichment examples. By correcting the operator used for environment variable fallbacks, the code now correctly handles credential initialization, ensuring that the system properly defaults to environment variables when explicit parameters are not provided. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request corrects a logical error in both opensearch_connector.py and opensearch_enrichment.py by replacing the bitwise OR operator (|) with the logical or operator when resolving username and password fallback values from environment variables. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Assigning reviewers: R: @kennknowles added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Description
username | os.getenv(...)andpassword | os.getenv(...)withorso fallback to environment variables works correctly.TypeErrorwhenusername/passwordare strings orNonein:examples/notebooks/beam-ml/rag_usecase/opensearch_connector.pyexamples/notebooks/beam-ml/rag_usecase/opensearch_enrichment.pyTesting
Not run (not requested).