Skip to content

Fix OpenSearch username/password env fallback in examples#39111

Open
fallintoplace wants to merge 1 commit into
apache:masterfrom
fallintoplace:fix/opensearch-auth-fallback
Open

Fix OpenSearch username/password env fallback in examples#39111
fallintoplace wants to merge 1 commit into
apache:masterfrom
fallintoplace:fix/opensearch-auth-fallback

Conversation

@fallintoplace

Copy link
Copy Markdown

Description

  • Fix OpenSearch notebook examples that used bitwise OR for credential fallback.
  • Replaces username | os.getenv(...) and password | os.getenv(...) with or so fallback to environment variables works correctly.
  • Prevents TypeError when username/password are strings or None in:
    • examples/notebooks/beam-ml/rag_usecase/opensearch_connector.py
    • examples/notebooks/beam-ml/rag_usecase/opensearch_enrichment.py

Testing

Not run (not requested).

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a logic error in the OpenSearch connector and enrichment examples. By correcting the operator used for environment variable fallbacks, the code now correctly handles credential initialization, ensuring that the system properly defaults to environment variables when explicit parameters are not provided.

Highlights

  • Bug Fix: Replaced incorrect bitwise OR operators with logical OR operators for OpenSearch credential fallback logic.
  • Error Prevention: Resolved potential TypeError exceptions that occurred when attempting to use bitwise operations on string or None types.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a logical error in both opensearch_connector.py and opensearch_enrichment.py by replacing the bitwise OR operator (|) with the logical or operator when resolving username and password fallback values from environment variables. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant