Repository navigation
Conversation
added 4 commits
October 9, 2026 08:48
Kanti
requested changes
Oct 9, 2026
Member
There was a problem hiding this comment.
remove file, is not needed. if we do not support ELTS versions.
| # docroot: <relative_path> # Relative path to the directory containing index.php. | ||
|
|
||
| # php_version: "8.3" # PHP version to use, "5.6" through "8.5" | ||
| # php_version: "8.5" # PHP version to use, "5.6" through "8.5" |
Member
There was a problem hiding this comment.
Suggested change
| # php_version: "8.5" # PHP version to use, "5.6" through "8.5" | |
| php_version: "8.5" # PHP version to use, "5.6" through "8.5" |
Comment on lines
+14
to
+15
| env: | ||
| COMPOSER_AUTH: ${{ secrets.TYPO3_ELTS_COMPOSER_AUTH }} |
Member
There was a problem hiding this comment.
Suggested change
| env: | |
| COMPOSER_AUTH: ${{ secrets.TYPO3_ELTS_COMPOSER_AUTH }} |
| @@ -11,18 +11,41 @@ jobs: | |||
| matrix: | |||
| php: [ '8.2', '8.3', '8.4', '8.5' ] | |||
| typo3: [ '12', '13' ] | |||
Member
There was a problem hiding this comment.
Suggested change
| typo3: [ '12', '13' ] | |
| typo3: [ '13' ] |
Comment on lines
+28
to
+51
| - name: Install the security-fixed SVG sanitizer in CI | ||
| run: | | ||
| alias=0.22.99 | ||
| if [ "${{ matrix.typo3 }}" = "11" ]; then alias=0.18.99; fi | ||
| composer require "enshrined/svg-sanitize:1.0.0 as $alias" --dev --no-update --sort-packages --no-interaction | ||
| - name: Configure TYPO3 ELTS when an authorized test license is available | ||
| if: (matrix.typo3 == '11' || matrix.typo3 == '12') && vars.TYPO3_ELTS_REPOSITORY_URL != '' | ||
| env: | ||
| TYPO3_ELTS_REPOSITORY_URL: ${{ vars.TYPO3_ELTS_REPOSITORY_URL }} | ||
| run: composer config --global repositories.typo3-elts composer "$TYPO3_ELTS_REPOSITORY_URL" | ||
| - run: composer require typo3/minimal="^${{ matrix.typo3 }}" --sort-packages --no-scripts -W --dev | ||
| - run: composer install --no-interaction --no-progress | ||
| - run: bash tests/typo3-svg-sanitizer.sh | ||
| - name: Run all static checks | ||
| shell: bash | ||
| run: | | ||
| set -o pipefail | ||
| ./vendor/bin/grumphp run --no-ansi 2>&1 | tee /tmp/php85-grumphp.log | ||
| - name: Report failed static checks | ||
| if: failure() | ||
| run: | | ||
| if [ -f /tmp/php85-grumphp.log ]; then | ||
| php -r '$s=file_get_contents("/tmp/php85-grumphp.log"); echo "::error::".str_replace(["%", "\r", "\n"], ["%25", "%0D", "%0A"], substr($s, -5000))."\n";' | ||
| fi |
Member
There was a problem hiding this comment.
Suggested change
| - name: Install the security-fixed SVG sanitizer in CI | |
| run: | | |
| alias=0.22.99 | |
| if [ "${{ matrix.typo3 }}" = "11" ]; then alias=0.18.99; fi | |
| composer require "enshrined/svg-sanitize:1.0.0 as $alias" --dev --no-update --sort-packages --no-interaction | |
| - name: Configure TYPO3 ELTS when an authorized test license is available | |
| if: (matrix.typo3 == '11' || matrix.typo3 == '12') && vars.TYPO3_ELTS_REPOSITORY_URL != '' | |
| env: | |
| TYPO3_ELTS_REPOSITORY_URL: ${{ vars.TYPO3_ELTS_REPOSITORY_URL }} | |
| run: composer config --global repositories.typo3-elts composer "$TYPO3_ELTS_REPOSITORY_URL" | |
| - run: composer require typo3/minimal="^${{ matrix.typo3 }}" --sort-packages --no-scripts -W --dev | |
| - run: composer install --no-interaction --no-progress | |
| - run: bash tests/typo3-svg-sanitizer.sh | |
| - name: Run all static checks | |
| shell: bash | |
| run: | | |
| set -o pipefail | |
| ./vendor/bin/grumphp run --no-ansi 2>&1 | tee /tmp/php85-grumphp.log | |
| - name: Report failed static checks | |
| if: failure() | |
| run: | | |
| if [ -f /tmp/php85-grumphp.log ]; then | |
| php -r '$s=file_get_contents("/tmp/php85-grumphp.log"); echo "::error::".str_replace(["%", "\r", "\n"], ["%25", "%0D", "%0A"], substr($s, -5000))."\n";' | |
| fi | |
| - run: composer require typo3/minimal="^${{ matrix.typo3 }}" --dev --ignore-platform-req=php+ | |
| - run: composer install --no-interaction --no-progress --ignore-platform-req=php+ | |
| - run: ./vendor/bin/grumphp run --ansi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds or verifies PHP 8.5 while retaining every previously supported PHP and TYPO3 release. Existing static, unit and functional jobs stay enabled, and platform requirements are checked without upper-bound overrides.
CI-only SVG sanitizer alias installs and tests the official security-fixed 1.0.0 release. TYPO3 11/12 matrices currently cannot resolve safe public core releases: an ELTS Composer source and authorized CI credentials are required. The requested existing TYPO3 support is retained; this PR remains a draft until the complete matrix passes.