Repository navigation
Conversation
Author
|
Kanti's requirements from the previous review:
|
Kanti
reviewed
Oct 27, 2026
Comment on lines
+26
to
+30
| - run: composer require "enshrined/svg-sanitize:~1.0.0" --dev --no-update --sort-packages --no-interaction | ||
| - run: composer require typo3/minimal="^${{ matrix.typo3 }}" --sort-packages --no-scripts -W --dev | ||
| - run: composer install --no-interaction --no-progress | ||
| - name: Run all static checks | ||
| run: ./vendor/bin/grumphp run --no-ansi |
Member
There was a problem hiding this comment.
Suggested change
| - run: composer require "enshrined/svg-sanitize:~1.0.0" --dev --no-update --sort-packages --no-interaction | |
| - run: composer require typo3/minimal="^${{ matrix.typo3 }}" --sort-packages --no-scripts -W --dev | |
| - run: composer install --no-interaction --no-progress | |
| - name: Run all static checks | |
| run: ./vendor/bin/grumphp run --no-ansi | |
| - run: composer require typo3/minimal="^${{ matrix.typo3 }}" --dev --ignore-platform-req=php+ | |
| - run: composer install --no-interaction --no-progress --ignore-platform-req=php+ | |
| - run: ./vendor/bin/grumphp run --ansi |
added 4 commits
October 29, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict Composer, extension metadata and CI to TYPO3 13.4, and retain the existing static checks. Add small configuration type annotations and update the DDEV PHP version hint.
Breaking change: legacy TYPO3 support is removed; the new development branch requires TYPO3 13.4.
Validation: the GitHub Actions branch workflow passed for
99d3650d51b9f6c88147cf98d5771e8c9304962f. This PR targetsmain.