Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/braket/jobs/metrics_data/log_metrics_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class LogMetricsParser:
convenient format.
"""

METRICS_DEFINITIONS = re.compile(r"(\w+)\s*=\s*([^;]+)\s*;")
METRICS_DEFINITIONS = re.compile(r"([^\s=;]+)\s*=\s*([^;]+)\s*;")
TIMESTAMP = "timestamp"
ITERATION_NUMBER = "iteration_number"
NODE_ID = "node_id"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import pytest

from braket.jobs.metrics import log_metric
from braket.jobs.metrics_data import LogMetricsParser
from braket.jobs.metrics_data.definitions import MetricStatistic, MetricType

Expand Down Expand Up @@ -202,3 +203,26 @@ def test_get_all_metrics_complete_results(log_events, metric_type, metric_stat,
for log_event in log_events:
parser.parse_log_message(log_event.get("timestamp"), log_event.get("message"))
assert parser.get_parsed_metrics(metric_type, metric_stat) == metrics_results


@pytest.mark.parametrize("statistic", [MetricStatistic.MIN, MetricStatistic.MAX])
def test_logged_metric_names_are_preserved(capsys, statistic):
values = {
"train/loss": 0.8,
"eval/loss": 0.2,
"energy-error": -0.5,
"energy.mean": 1.5,
"energy_mean": 2.5,
}
for name, value in values.items():
log_metric(name, value, timestamp=1.0, iteration_number=3)

parser = LogMetricsParser()
for line in capsys.readouterr().out.splitlines():
parser.parse_log_message("fallback timestamp", line)

assert parser.get_parsed_metrics(MetricType.ITERATION_NUMBER, statistic) == {
"timestamp": [1.0],
"iteration_number": [3.0],
**{name: [value] for name, value in values.items()},
}
Loading