Repository navigation
Conversation
Signed-off-by: Rio Yu <52408936+rioyu123@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
log_metricwrites names such astrain/lossandeval/lossunchanged, butLogMetricsParserreads both asloss. The metrics end up in one column, where MIN/MAX selects between unrelated values. Hyphens and periods also cause names to lose their prefixes.This change preserves the complete non-whitespace name token before
=. Value parsing, delimiters and statistics handling are unchanged. Names containing whitespace,=or;remain outside this fix.Punctuated names now appear under their full name instead of the truncated suffix. Hand-formatted logs should separate names from preceding text with whitespace, as
log_metricalready does.Testing done:
log_metricoutput and check slash, hyphen, period and underscore names under MIN and MAX. Both fail on the original parser.tox -e linters_check,type-check,docs,coverage-checkpassed; coverage is 100%. The docs build completed with 467 warnings.Merge Checklist
General
No documentation change is needed for this parser correction.
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.