Repository navigation
Conversation
This was referenced Oct 19, 2026
nichwall
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
Prepare incremental backend TypeScript migrations with strict type-aware ESLint, a no-output type-check command, and CI type checking. No application JavaScript is migrated in this PR.
Which issue is fixed?
No linked issue. This is preparatory tooling for incremental backend TypeScript migration.
In-depth Description
typecheck:serverandclean:servercommands and enable strict, type-aware ESLint for backend TypeScript and type contracts. Keep the existing JavaScript lint rules.global.isWindeclaration loads without an explicit import and remainsboolean | undefined.server/libs/fluentFfmpeg/index.d.tsexcluded from compiler roots. Including it shadowsindex.jsduring file discovery and omits the runtime entry from compiled output. All 462 existing JavaScript compiler roots are preserved.How have you tested this?
Validated locally on Node.js 24.22.0:
npm ci --no-audit --no-fund npm run typecheck:server npm run lint npm run clean:server npm run build:server node -e "require('./dist-server/server/libs/fluentFfmpeg')" npx --no-install mocha dist-server/test/server/controllers/LibraryController.test.js dist-server/test/server/utils/requestUtils.test.jsThe targeted suites passed all 8 tests using in-memory databases. An in-memory compiler check confirmed that omitting the ambient declaration causes the type contract to fail. Comparing compiler roots against master confirmed that no existing JavaScript inputs were lost.
CI passed on the same commit in the fork:
No functional manual testing is required for this tooling-only change. The full test suite ran in CI rather than locally.
Screenshots
Not applicable; no web client changes.