Repository navigation
Conversation
This was referenced Oct 19, 2026
nichwall
approved these changes
Oct 24, 2026
nichwall
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good to me. I ran typecheck:server, lint, build:server, build-linux, build-win-no-compress, and docker-amd64-local successfully on all 3 PRs in this series and started the dev server.
Author
Thanks for reviewing and testing all three PRs! Would you prefer me to wait until these are merged, or should I continue submitting small, incremental PRs for the TypeScript migration? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary
Migrate general backend helpers to strict TypeScript while preserving their CommonJS exports and runtime behavior.
Depends on #5665, which depends on #5664. Merge order: #5664, #5665, then this PR. Until the preceding PRs merge, GitHub's master-based diff includes their commits. Review only this batch.
Which issue is fixed?
No linked issue. This is the second application-code batch of the incremental backend TypeScript migration.
In-depth Description
How have you tested this?
Validated on Node.js 24.22.0:
All 40 targeted tests passed. The rate-limiter suite exercises real HTTP requests on an ephemeral localhost port, and timeout cases use fake timers. Native query-value string conversion is retained without weakening strict ESLint.
Verified
git diff-tree --no-commit-id --name-status -r -M 4e4efcefreports eight R100 renames. A build-output check confirmed all 462 existing JavaScript output paths from master remain present. No additional functional manual testing is required for this batch; full unit and packaging/startup checks run in the existing fork CI.CI passed on the same commit in the fork:
Upstream workflows currently require maintainer approval before running.
Screenshots
Not applicable; no web client changes.