Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The valid 7.0 branch pin and corresponding workflow cleanup are consistent and complete.
Pull request overview
Pins wp-env to WordPress Core’s 7.0 maintenance branch and simplifies PHP CI accordingly.
Changes:
- Pins both wp-env configurations to
WordPress/WordPress#7.0-branch. - Removes the previous-version lookup and WordPress matrix dimension.
File summaries
| File | Description |
|---|---|
.wp-env.test.json |
Pins test environments to WordPress 7.0. |
.wp-env.json |
Pins the default environment to WordPress 7.0. |
.github/workflows/unit-test.yml |
Removes obsolete multi-version PHP testing logic. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
4a4849a to
3dc8e58
Compare
3dc8e58 to
98ff0c6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
98ff0c6 to
93a91ee
Compare
Part of #82782.
What?
Pins
wp-env's WordPress core checkout toWordPress/WordPress#7.0-branchvia.wp-env.json's"core"value, and removes thewordpresstest matrix dimension, theWP_ENV_COREenvironment variable override, and thecompute-previous-wordpress-versionjob it depended on fromunit-test.yml'stest-phpjob.Why?
.wp-env.json's"core"value was unpinned ("WordPress/WordPress"), so every PHP unit test run built its WordPress environment against whatever commit happened to be on WordPress Core's owntrunkat run time. That makestest-phpnon-reproducible and ties this frozen branch's CI to unrelated, ongoing changes on a different project's default branch — the opposite of what a maintenance branch's CI should depend on. Pinning to Core's own7.0-branchtests against the WordPress version this Gutenberg branch is actually meant to run alongside, and removing the "previous major version" matrix leg (along with the job that computed which version that was) drops a comparison that only made sense while tracking Core's movingtrunk.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.