Skip to content

Repair wp/7.0 branch Actions: Pin wp-env's WordPress Core version - #145

Closed
desrosj wants to merge 1 commit into
fix-actions-7.0/single-node-version-testingfrom
fix-actions-7.0/pin-wp-env-core-version
Closed

desrosj wants to merge 1 commit into
fix-actions-7.0/single-node-version-testingfrom
fix-actions-7.0/pin-wp-env-core-version

Conversation

@desrosj

@desrosj desrosj commented Sep 1, 2026

Copy link
Copy Markdown
Owner

What?

Pins wp-env's WordPress core checkout to WordPress/WordPress#7.0-branch via .wp-env.json's "core" value, and removes the wordpress test matrix dimension, the WP_ENV_CORE environment variable override, and the compute-previous-wordpress-version job it depended on from unit-test.yml's test-php job.

Why?

.wp-env.json's "core" value was unpinned ("WordPress/WordPress"), so every PHP unit test run built its WordPress environment against whatever commit happened to be on WordPress Core's own trunk at run time. That makes test-php non-reproducible and ties this frozen branch's CI to unrelated, ongoing changes on a different project's default branch — the opposite of what a maintenance branch's CI should depend on. Pinning to Core's own 7.0-branch tests against the WordPress version this Gutenberg branch is actually meant to run alongside, and removing the "previous major version" matrix leg (along with the job that computed which version that was) drops a comparison that only made sense while tracking Core's moving trunk.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from a60b654 to 5b1e679 Compare September 1, 2026 14:06
@desrosj
desrosj removed this pull request from stack #151 September 10, 2026 18:21
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from 5b1e679 to d3376ee Compare September 10, 2026 18:22
@desrosj
desrosj added this pull request to stack #179 September 10, 2026 18:22
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from d3376ee to d1aa805 Compare September 10, 2026 18:40
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from d1aa805 to e4ba88f Compare September 10, 2026 20:08
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Flaky tests detected in 324a3d7.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/desrosj/gutenberg/actions/runs/34634343874
📝 Reported tests:

should undo typing after non input change in /test/e2e/specs/editor/various/undo.spec.js, passed after 1 failed attempt.
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Object {
    "blockIndex": 0,
-   "endOffset": 16,
-   "startOffset": 16,
+   "endOffset": 4,
+   "startOffset": 4,
  }

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/undo.spec.js:122:3

@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from e4ba88f to 18d3739 Compare September 10, 2026 23:50
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from 18d3739 to 7a3213d Compare September 11, 2026 00:27
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch 2 times, most recently from 186830e to a884c86 Compare September 11, 2026 01:35
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from a884c86 to 5bfd1ec Compare September 11, 2026 02:19
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 02:30
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from 5bfd1ec to 5159935 Compare September 11, 2026 02:33
@desrosj
desrosj marked this pull request as draft September 11, 2026 03:21
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from 5159935 to 4908534 Compare September 11, 2026 17:03
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 18:16
Pins wp-env's WordPress core checkout to `WordPress/WordPress#7.0-branch` via both `.wp-env.json`'s and `.wp-env.test.json`'s `"core"` value, and removes the `wordpress` test matrix dimension, the `WP_ENV_CORE` environment variable override, and the `compute-previous-wordpress-version` job it depended on from `unit-test.yml`'s `test-php` job.

Both `.wp-env.json` and `.wp-env.test.json`'s `"core"` values were previously unpinned (`"WordPress/WordPress"`), so every PHP unit test run built against whatever commit happened to be on WordPress Core's own `trunk` at run time. That makes results non-reproducible and ties this frozen branch's CI to changes on a codebase it has no relationship to. Pinning both files to Core's own `7.0-branch` tests against a WordPress version this Gutenberg branch is actually meant to run alongside. `.wp-env.test.json` was missed in the original version of this commit — this branch is the first to carry that file, and its own `"core"` pin was overlooked alongside `.wp-env.json`'s.
@desrosj
desrosj force-pushed the fix-actions-7.0/pin-wp-env-core-version branch from 4908534 to 324a3d7 Compare September 11, 2026 18:37
@desrosj

desrosj commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Migrated to real upstream: WordPress#82802. Closing this fork PR.

@desrosj desrosj closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant