Skip to content

fix: reconcile orphaned in_progress sync_history rows on startup #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilo-WATT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reconcile orphaned in_progress sync_history rows on startup #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions list_sync/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,28 @@ def init_database():
# Indexes might already exist
pass

# Reconcile orphaned sync_history rows left in_progress by a process that
# was killed/restarted mid-sync (container restart, OOM, crash, etc.).
# Without this, /api/sync/status/live keeps reporting "running" forever
# for a session whose process no longer exists, since nothing else ever
# closes these rows out.
try:
cursor.execute('''
UPDATE sync_history
SET in_progress = 0,
end_time = CURRENT_TIMESTAMP,
status = 'interrupted'
WHERE in_progress = 1 AND end_time IS NULL
''')
if cursor.rowcount:
logging.warning(
f"Reconciled {cursor.rowcount} orphaned sync_history row(s) "
"left in_progress by a previous process that didn't exit cleanly"
)
except sqlite3.OperationalError:
# Table may not exist yet on a brand new database; nothing to reconcile
pass

# Overseerr users table - stores synced Overseerr users
cursor.execute('''
CREATE TABLE IF NOT EXISTS overseerr_users (
Expand Down