Repository navigation
fix(maestro-flow): keep Extract document out of an SDK-sourced project #4635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cezara98t
wants to merge
6
commits into
main
Choose a base branch
from
fix/extract-document-eval-failures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9
−3
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
700b3ca
fix(maestro-flow): keep Extract document out of an SDK-sourced projec…
cezara98t 3ea8ee9
test(maestro-flow): copy_taxonomy rejects a synthesised processorKey,…
cezara98t 430f1a6
test(maestro-flow): copy_taxonomy grades the taxonomy Credit Note wil…
cezara98t 258249f
test(maestro-flow): copy_taxonomy checks the processorKey in the task…
cezara98t e672e00
test(maestro-flow): move the copy_taxonomy change to its own PR
cezara98t 6b0d86d
fix(maestro-flow): key the Extract document redirect on a supplied so…
cezara98t File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blocker][Correctness & logic] Distinguish source ownership from SDK caches
A
.flow-sdk/directory can hold only bindings and connector caches; SKILL.md calls it the SDK work directory, and registry prepare writes there. Its presence does not prove a maintained.flow.tsowns this Flow. This new step-0 guard also applies before edits to an existing extraction node, so a CLI-authored Flow with caches gets redirected to another project instead of receiving the requested edit. Check actual source ownership and cover a cache-only directory; do not treat every.flow-sdk/as authoritative TypeScript.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 6b0d86d. The redirect now keys on a supplied source, the same test
SKILL.mdandbrownfield.mduse for "A supplied source": a.flow-sdk/<Name>.flow.tsthe task handed over, not one decompiled for an edit. It applies only to adding a new node..flow-sdk/holding onlybindings.json,connectors/orconnectors-local/is called out as the SDK's cache: edit the.flowas usual.Step 0, the "Adding the node" paragraph and the
SKILL.mdsentence all use the same test. The Studio Web flavor replaces all three, so its output is unchanged.