Repository navigation
Conversation
…t; grade copy_taxonomy on the key it must not copy sdk_project failed on the coding agent: the agent read the separate-project rule and still edited PermitDesk.flow in place, leaving .flow-sdk/PermitDesk.flow.ts stale so the user's next compile deletes the node. The rule sat as prose below the numbered loop the agent follows, and SKILL.md's "existing project: edit its .flow" line carried no exception for it. Put the .flow-sdk/ check in loop step 0, turn the rule into steps (leave the project, init a new one without --sdk-source, tell the user why), and name the case in SKILL.md. All three passages sit in blocks the studioweb flavor replaces, so Studio Web, where the .flow is authoritative, is unchanged. copy_taxonomy asserted Extract Credit Note has no processorKey. A CLI that provisions a processor on `nodes schema set` gives it a fresh key of its own, which is correct; assert instead that it is not Extract Invoice's key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… not only a copied one The inequality check passed any key that was not Extract Invoice's, so a made-up GUID with no processor behind it graded as correct. A helper now accepts no key, or a key an idpProcessor resource in the solution declares. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @cezara98t's task in 53s —— View job Coder-eval task lint (advisory)1 task YAML changed. Verdict counts: 0 Critical, 0 High, 0 Medium, 1 Low, 0 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run
Per-task lint
|
|
Claude finished @cezara98t's task in 1m 20s —— View job SummaryThis PR fixes two failing Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Not touched |
| E2E Tests | Issue | sdk_project has no passing-run claim yet |
| Skill Body | OK | Rule moved into the numbered loop; flavor blocks respected |
| References & Assets | OK | Links resolve (#adding-the-node, document-pipeline.md, extract-document-taxonomy.md#starting-from-a-flow-in-studio-web) |
| Repo Hygiene | OK | No secrets or personal paths; the GUIDs are fixture data |
Issues for Manual Review
- Does a separate project answer the user's request? The user asked for the step in their flow. Step 3 explains why it isn't there, but says nothing about connecting the new project back to PermitDesk (for example, as a called flow). A domain owner should decide whether that belongs in this guidance.
- Is processor provisioning stable? Confirm that
uip 1.207provisioning onnodes schema setis the intended, lasting behaviour. The helper's "no key also passes" branch keeps older CLIs green. - Studio Web host exclusion for
sdk_project(follow-up 1) needs the runner owner to agree. Nothing in this repo can do it today.
Conclusion
Approve once the sdk_project rerun passes. The skill change targets the root cause shown in the failing transcript and keeps the studioweb flavor unchanged. The new copy_taxonomy criterion is stricter than the old one where it counts: it still rejects copied keys and also catches synthesised ones. The only blocker is the missing passing run. Fold the helper into the shared checker after test/extract-document-processor lands.
…l extract with A node extracts with the processor its processorKey names, and that processor holds its own copy of the taxonomy. Checking only that the key is not Invoice's, or that a resource declares it, passed a processor still holding the old schema. The helper now also requires the provisioned resource's prompt and output schema to equal the copied ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, drop the helper Validate already refuses a keyless node and a second author, and schema set and pack keep the resource in step with the node, so only a copied read-only key is left to check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rockymadden
left a comment
There was a problem hiding this comment.
🟡 Commented · Fix the open blocker before merge.
What
Moves the Extract document SDK-source guard ahead of the editing loop and makes the separate-project instruction explicit.
Axes
| Axis | Blockers | Non-blockers | Top finding |
|---|---|---|---|
| Correctness & logic | 1 | 0 | Distinguish source ownership from SDK caches · skills/uipath-maestro-flow/references/extract-document-node.md:44 |
| Code quality & simplicity | 0 | 0 | none |
| Types & contracts | 0 | 0 | none |
| Tests & validation | 0 | 1 | Validate the affected SDK-project task |
| Security | 0 | 0 | none |
| Architecture & design | 0 | 0 | none |
| Error handling & resilience | 0 | 0 | none |
| Interface, docs & compatibility | 0 | 0 | none |
Overall findings
- [non-blocker][Tests & validation] Validate the affected SDK-project task
The changed behavior targets sdk_project, but that task is absent from the passing34-task CI artifact and the body states there is no passing run for it. Run that task with a coding agent after the source guard is fixed, including a cache-only project case.
Validation
Read both changed files, project-layout/binding guidance, task context and matching Studio Web overrides. Head-matching smoke CI passed34tasks but did not include sdk_project. Studio Web replaces all three touched guidance blocks. No local tests, builds or live service writes performed.
tl;dr: 1 blocker, 1 non-blocker.
| <!--skill-flavor:extract-find-flow:start--> | ||
| 0. **Find the flow.** Everything here edits a `.flow` on disk. When the user describes a flow they are already building and none exists locally, they may be referring to one | ||
| that lives in Studio Web and has to be pulled down first — ask them for its URL or solution id, since nothing lists them ([Starting from a flow in Studio Web](extract-document-taxonomy.md#starting-from-a-flow-in-studio-web)). | ||
| that lives in Studio Web and has to be pulled down first — ask them for its URL or solution id, since nothing lists them ([Starting from a flow in Studio Web](extract-document-taxonomy.md#starting-from-a-flow-in-studio-web)). **Where the project folder holds `.flow-sdk/`, do not edit its `.flow`:** that flow is compiled from TypeScript source, so the node goes in a separate project ([Adding the node](#adding-the-node)), and every later step runs on that project's `.flow`. |
There was a problem hiding this comment.
[blocker][Correctness & logic] Distinguish source ownership from SDK caches
A .flow-sdk/ directory can hold only bindings and connector caches; SKILL.md calls it the SDK work directory, and registry prepare writes there. Its presence does not prove a maintained .flow.ts owns this Flow. This new step-0 guard also applies before edits to an existing extraction node, so a CLI-authored Flow with caches gets redirected to another project instead of receiving the requested edit. Check actual source ownership and cover a cache-only directory; do not treat every .flow-sdk/ as authoritative TypeScript.
There was a problem hiding this comment.
Fixed in 6b0d86d. The redirect now keys on a supplied source, the same test SKILL.md and brownfield.md use for "A supplied source": a .flow-sdk/<Name>.flow.ts the task handed over, not one decompiled for an edit. It applies only to adding a new node.
- A
.flow-sdk/holding onlybindings.json,connectors/orconnectors-local/is called out as the SDK's cache: edit the.flowas usual. - A flow that already holds an Extract document node is edited in place, so an edit to an existing node is no longer redirected.
Step 0, the "Adding the node" paragraph and the SKILL.md sentence all use the same test. The Studio Web flavor replaces all three, so its output is unchanged.
…urce A `.flow-sdk/` directory alone does not mean TypeScript owns the flow: it also holds the SDK's caches (`bindings.json`, `connectors/`, `connectors-local/`), and a decompile for an edit writes a working `<Name>.flow.ts` there too. The redirect now applies only to a project whose `.flow-sdk/<Name>.flow.ts` the task supplied, and only to a new node. A cache-only `.flow-sdk/` and a flow that already holds the node are edited in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Run: claude-code, Opus 5.5, canonical skill, score 0.0. The agent read
extract-document-node.mdin full, then editedPermitDesk.flowin place and left.flow-sdk/PermitDesk.flow.tsstale. It even warned the user not to compile the source, because the next compile deletes the node. That is the damage the separate-project rule exists to prevent.Why the rule lost:
.flow-sdk/.SKILL.mdsays a project that already exists is edited through its.flow, with no exception. It covered Extract document only for a new flow ("drop--sdk-source").Changes:
.flow-sdk/<Name>.flow.tsstops here for a new node, which goes in a separate project. A cache-only.flow-sdk/(bindings.json,connectors/,connectors-local/) and a flow that already holds the node are edited in place.flow init <NewName>without--sdk-source, then tell the user why.SKILL.md: the Extract document sentence names the supplied-source case. It is folded into the existing line because the "Project layout" section is at its byte budget.All three passages are inside blocks the studioweb flavor replaces (
extract-find-flow,extract-sdk-mixing,sdk-project-layout). Studio Web output is unchanged, which is intended. There the.flowis authoritative and.flow-sdk/is a per-turn draft, so the flavor deliberately edits in place.Proof
sdk_project: not reproduced locally. It needs a coder-eval run. The evidence is the failing run's transcript: the agent read the rule, then edited in place. No passing-run claim yet, so a rerun ofskill-flow-extract-document-sdk-projecton the claude-code agent is needed before merge.Checks run locally:
npm run skills:validateandskills:build: OK. The studioweb tree has none of the new text.test_skill_size_budget.pyandtest_brownfield_turn_rules.py: 21 passed ("Project layout" at 8,497 of 8,500 bytes).check-sensitive-content.py: OK.uipath-plannertest, all failing on atrimof undefined from npm-pack output. None touchuipath-maestro-flow, and they look tied to the local npm.Not run here: the coder-eval tasks themselves (eval sandbox and tenant).
The
copy_taxonomycriterion fix moved to #4650.Follow-ups, not in this PR
sdk_projectoff the Studio Web agent. It fails there too (studio-web, gpt-5-6-luna, studioweb flavor), but correctly: the flavor tells the agent to edit the.flowin place. The repo has no way to exclude a task from a host, and the Studio Web runner picks tasks outside this repo. The tag vocabulary is closed, so this needs agreement with the runner owner. A candidate is a flat marker such ascoding-agent-onlyintests/README.md§ Tag Taxonomy, honoured by the runner.extract-document-node.mdstill says "Nothing in the CLI provisions one" and tells the user to save in Studio Web.uip 1.207provisions a processor onnodes schema set. The tests ontest/extract-document-processoralready assume it does.🤖 Generated with Claude Code