Skip to content

Point uipath-maestro-case at the planner's case product guide (5/6) [PILOT-9071] - #4358

Merged
RaduAna-Maria merged 1 commit into
mainfrom
feat/genome-stack-5-studioweb-flavors
Nov 12, 2026
Merged

RaduAna-Maria merged 1 commit into
mainfrom
feat/genome-stack-5-studioweb-flavors

Conversation

@RaduAna-Maria

@RaduAna-Maria RaduAna-Maria commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

PILOT-9071

Stack 5 of 6 (#4327 → #4328 → #4329 → #4330 → #4358 → #4379), merged together.

Summary

  • Point uipath-maestro-case and its tasks at design/case-product-guide.md
  • Drop the sdd-viewer.html mention and references/evals/evals.json
  • Case fixtures carry Tasks file, not Build handoff

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @RaduAna-Maria's task in 1m 21s —— View job


Review of PR #4358: Studio Web overrides for the planner verbs and the genome split (5/5)

  • Gather context (diff, review criteria, CLAUDE.md, flavor rules)
  • Check overrides line up with canonical flavor blocks
  • Check links and anchors in the overrides
  • Post review

Summary

This PR moves the stack's skill-flavors/studioweb/ changes into one place. It renames the planner overrides to match the new verb guides, splits sdd-generation-guide into design-guide and sdd-writing-guide, adds Studio Web overrides for host-tools-task-list and the Pattern 7 deploy step, and moves the genome execution override to uipath-build-from-genome.

Change-by-Change Review

1. Override blocks match the canonical blocks

OK. All 41 start markers under skill-flavors/studioweb/{uipath-planner,uipath-build-from-genome}/ match a canonical block of the same name, at the mirrored path under skills/. Each block is overridden once, with no orphaned blocks on either side.

  • Old names are gone: skill-flavors/studioweb/uipath-genome/ no longer exists.
  • No stale words are left in any flavor: pdd-driven-lane-guide, non-pdd-lane-guide, sdd-generation-guide, case-design-lane-guide, genome-format-guide, Lane A, Lane B and Phase D all return zero matches.

2. Links and anchors in the overrides

OK. Every target resolves against the composed file's location:

  • plan-and-tasks-format.md#decompose-featuremd → ### `decompose` (`<feature>.md`) (line 12)
  • #regenerate-logic → line 144
  • #plan-mode-integration → line 218
  • sdd-writing-guide.md#step-0-write-the-sdd-skeleton-to-disk--hard-gate → line 18. This link was a same-file anchor before; it now points across files, which is correct after the split.
  • genome-reading-guide.md § Two Levels and source-migration-guide.md § Source steps that are not UI actions both exist in uipath-build-from-genome/references/.
  • plan-guide.md resolves from multi-skill-patterns-guide.md.

3. skill-flavors/studioweb/uipath-planner/SKILL.md: host-tools-task-list and plan-job

Low. The new override ends with ;, so it reads correctly between the canonical "structured question" clause and the "plan mode" clause (skills/uipath-planner/SKILL.md:14-18). Two small inaccuracies:

  • host-tools-task-list (line 15): "the host derives the task list from the approved plan, and the tasks file records progress" leaves out the decompose simultaneous path. That path has no plan mode, and its dated plan is the task list. The canonical fallback covers this ("the tasks file or plan is the task list"). Suggested wording: "…from the approved plan; otherwise the tasks file or dated plan is the task list."
  • plan-job, decompose row (line 3): "reviewed through plan mode, the host derives the live task list from it" sounds unconditional. It only applies to explore-first; plan-and-tasks-format.md's live-tasks-and-plan-mode block states this correctly. Suggested wording: "explore-first: reviewed through plan mode, the host derives the live task list from it."

4. design-guide.md / sdd-writing-guide.md (split from sdd-generation-guide.md)

OK. The four blocks are spread correctly: progress-tasks goes to design-guide; phase3-output-surface, turn-boundary, and phase-d-deliverable renamed to design-deliverable go to sdd-writing-guide. The two blocks that moved out of SKILL.md (sdd-no-task-lists and solution-terminal-artifact) are renumbered to the canonical list positions (2 and 6), matching skills/uipath-planner/references/design-guide.md:10,16. The turn-boundary override still fits the canonical "Then continue:" list that follows it (sdd-writing-guide.md:256).

  • Nit (Low): sdd-writing-guide.md:9 keeps AskUserQuestion, but the canonical block now uses the host-neutral "structured question". This is harmless because the Studio Web flavor uses AskUserQuestion elsewhere (maestro-case, maestro-flow overrides).

5. multi-skill-patterns-guide.md: genome-build-deploy-step

OK. The override fits Studio Web: no pack step, and publishing is the user's call. The Orchestrator fallback for when the constraint gate blocks Solutions is kept, and it correctly drops the canonical design-guide.md Verb Rule 6 reference to the .uipx packing.

6. plan-and-tasks-format.md: task-row-tool-fields

OK. Adding uipath-build-from-genome (Pattern 7 only) keeps the Studio Web skill list in sync with the canonical change.

What's Missing

  • Nothing identified. No new skill folders, so CODEOWNERS, skill-status.json and skills.sh.json don't change. No secrets or personal paths.

Area Ratings

Area Status Notes
Frontmatter OK No frontmatter touched
E2E Tests OK Flavor-only move; contract tests reported 19/19
Skill Body OK Two Low wording issues in the SKILL.md override
References & Assets OK All block names and links resolve
Repo Hygiene OK Scoped to skill-flavors/studioweb/

Issues for Manual Review

  • I couldn't run npm run skills:validate, skills:build or skills:pack (the commands needed approval in this runner), so the block matching above was checked by grep, not by the composer. Please confirm Build and inspect every skill package is green on this PR, and inspect the Studio Web tarball as CLAUDE.md asks.
  • The "git diff <old #4330 head> HEAD is empty" claim depends on the stack's history and wasn't re-checked here.

Conclusion

Approve, with optional nits. The move is clean and every override lines up with a canonical block. The two Low wording fixes in item 3 are optional.

@RaduAna-Maria
RaduAna-Maria added this pull request to stack #4331 November 3, 2026 10:21
@RaduAna-Maria
RaduAna-Maria marked this pull request as draft November 3, 2026 10:21
@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch from dcc2119 to 9c5ff4a Compare November 3, 2026 13:57
@RaduAna-Maria RaduAna-Maria changed the title Studio Web overrides for the planner verbs and the genome split (5/5) [PILOT-9071] Studio Web overrides for the planner verbs and the genome split (5/6) [PILOT-9071] Nov 3, 2026
@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch from 9c5ff4a to d594aa9 Compare November 4, 2026 13:34
@RaduAna-Maria RaduAna-Maria changed the title Studio Web overrides for the planner verbs and the genome split (5/6) [PILOT-9071] Point uipath-maestro-case at the planner's case product guide (5/6) [PILOT-9071] Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

skill-lint: no new errors or warnings

Only what this PR adds is listed, compared with the commit it branched from; issues already on the base branch are not. Updated on every push.

@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch from d594aa9 to e6bd131 Compare November 4, 2026 14:52
@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch from e6bd131 to 00855fa Compare November 4, 2026 16:15
@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch from 00855fa to beb4c27 Compare November 4, 2026 16:17
@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch 4 times, most recently from 4f23464 to 805bae3 Compare November 5, 2026 15:01
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Smoke test coverage gap — the following changed skills have no tests under tests/tasks/:

  • uipath-genome

Consider adding smoke tests before merging.

@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch from c839c4f to f0f60e2 Compare November 11, 2026 09:25
@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch 4 times, most recently from 1e6744e to 0e33751 Compare November 12, 2026 08:56
Base automatically changed from feat/genome-stack-4-sdd-and-genome to main November 12, 2026 08:57
Drops the sdd-viewer.html mention and the stale evals file, and updates
the case tasks for the moved planner guide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RaduAna-Maria
RaduAna-Maria force-pushed the feat/genome-stack-5-studioweb-flavors branch from 0e33751 to 1b8033f Compare November 12, 2026 08:57
@RaduAna-Maria
RaduAna-Maria merged commit 03d496f into main Nov 12, 2026
36 of 40 checks passed
@RaduAna-Maria
RaduAna-Maria deleted the feat/genome-stack-5-studioweb-flavors branch November 12, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants