Repository navigation
Add uipath-build-from-genome in its final form (1/6) [PILOT-9071] - #4327
Conversation
d33a4b3 to
3e14a65
Compare
3e14a65 to
9663f53
Compare
skill-lint: 0 new errors, 3 new warnings
What these rules check
Only what this PR adds is listed, compared with the commit it branched from; issues already on the base branch are not. Updated on every push. |
ad07ac7 to
6f5f204
Compare
danmunteanu1
left a comment
There was a problem hiding this comment.
🟡 Commented · 5 blockers · 8 non-blockers
Inline findings on the files this PR changes; the stack-wide summary and the main-drift list are on #4379.
danmunteanu1
left a comment
There was a problem hiding this comment.
🟡 Commented · 6 blockers · 5 non-blockers
Re-review: new findings on this PR's fix commits; replies are on the earlier threads, and the stack-wide summary is on #4379.
|
|
||
| The `context` call of [SKILL.md § Setup](../SKILL.md) has run; its fields decide the rows of § Read Plan below. `extracted` is true when the genome has a `## Source Map` that is not the stub; `transactional` is true when its Transactional Shape is not the stub, false for the stub, and null when the section is absent — null opens no transactional read and is a report item like the other findings below. `build_mode` `unknown` opens neither the migration row nor the refactor row until the Source Map's `Source framework` row, or the user's answer, names the framework ([SKILL.md § Setup](../SKILL.md)). | ||
|
|
||
| **A Build With or Components skill the host lacks** (found when the start row of § Read Plan invokes each named skill): name the skill and the components that need it, say the build needs it installed, and stop. |
There was a problem hiding this comment.
🔴 Blocker · A retired skill name now stops the build
A genome whose Build With names uipath-coded-workflows (a retired name) names a skill the host lacks, so this start-phase rule stops the build. The rule that a retired name "builds through uipath-rpa" (genome-reading-guide.md:33) is read only in the build phase (read-plan row :54), after the stop, and the checker reports a retired name as a report item, not a blocking FAIL.
Fix: except the retired names here ("…the host lacks, other than a retired name (genome-reading-guide.md § Build With and Components)"), and move the :54 row to the start phase.
There was a problem hiding this comment.
The build no longer stops on a retired name (e9efd78c7). The rule it now reaches (genome-reading-guide.md:33) builds all three retired names through uipath-rpa. But uipath-coded-agents was the Python coded agents skill, now uipath-agents (main e73afc26b), so a genome naming it gets an RPA project for an agent.
Fix: uipath-rpa-workflows and uipath-coded-workflows build through uipath-rpa; uipath-coded-agents builds through uipath-agents.
There was a problem hiding this comment.
Reproduced at bcf20b12a. I took the PR's exception-triage-agent-genome.md example and made its Build With row read `uipath-coded-agents` | Classifies the discrepancy and proposes a resolution. Then I asked for an unattended build, 3 runs (Opus 5.5, stopped at the first building skill). One run invoked uipath-rpa with "Build With row names retired skill uipath-coded-agents → builds through uipath-rpa. Coded C# workflow project"; the other two invoked uipath-agents. When the row's rationale says "Python coded agent", the agent overrides the rule (1/1). So the rule misroutes exactly the genomes that give no other hint.
There was a problem hiding this comment.
Downgrading this to a non-blocker. uipath-coded-agents was retired on 2026-04-02 and the planner's checker fails any genome that names it, so only a genome written before then can reach this rule. Simplest fix: drop uipath-coded-agents from the list here, so such a genome stops with the missing-skill rule (as main does) instead of building as an RPA project.
faf76b4 to
5ae6efe
Compare
danmunteanu1
left a comment
There was a problem hiding this comment.
🟡 Commented · 1 blocker
Re-review after the rebase: one new finding on this PR; the stack-wide summary is on #4379.
|
Follow-up for a few earlier replies: the genome checker has since moved into |
5ae6efe to
2fc06c6
Compare
Moves the build side of uipath-genome into its own skill: execution, parts, transactional, selector, migration and verification guides, the genome checker as check-genome.mjs, the Studio Web override, the build tasks and the checker tests. The registries, CODEOWNERS and activation config switch from uipath-genome to the new skill here, once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ader A blocking checker finding ended the build with a report; the planner's edit had no row that recognised it, so the build never ran again. The build now hands blocking findings to uipath-planner under one header the planner's edit matches, and the report's genome edits use the same header when the user forwards them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fixes: a blocking FAIL and a missing building skill each have one procedure (no CLI fallback); shape rule 8 and verb rule 9 honour a flow's Decided: line; the build reads only the genome, so an edit to a designed genome is never overridden by its SDD; Live application is asked for every genome with UI steps, defaulting from the Deployment line; an unattended build takes the Data Fabric default like every other question; the pack-dry-run stop becomes the last local gate. genome-reading-guide.md keeps only what the build does with each section, leaving the format to the planner. Ports from main the split left out: the job's log by default (#4403), disappear and multi-condition waits (#4435), the owning skill deciding helper workflows (#4436), two parts at once (#4441), one package version per run and record-store writers and readers (#4437), source fidelity and building into an existing project (#4506), and taking the source's values (#4519). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… reads it as a placeholder Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2fc06c6 to
ed95c51
Compare
danmunteanu1
left a comment
There was a problem hiding this comment.
🟡 Commented · 1 blocker. The re-review summary is on #4379.
Issue
PILOT-9071
Summary
uipath-build-from-genome(build·check): build-side guides moved fromuipath-genome(renames)check-genome.pywithscripts/check-genome.mjs(Node, built-ins only)uipath-genometo the new skilluipath-genome(run 41434186934)check-genome.mjs contextreturnsdesigned_in_fingerprint/designed_in_current; a changed SDD sends the genome to the planner'sedit, then the build continuesExecution autonomyno longer waives build questions; only the build request's own "take the defaults" doesDecided:split and theRequested changetopics are answered at build, never re-asked or confirmed🤖 Generated with Claude Code