Skip to content

Load memory-mapped speech archives on iOS #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tryk016 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Load memory-mapped speech archives on iOS #1008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/resources.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ void Resources::loadVdfs(const std::vector<std::u16string>& modvdfs, bool modFil

for(auto& i:archives) {
try {
#ifdef __IOS__
// causes OOM on iPhone7
#if defined(__IOS__) && !defined(_ZK_WITH_MMAP)

@Try Try Oct 8, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ZK_WITH_MMAP is enabled by default, at least right now.
I need to get back to it and test again, if it works on iPhone7. It should be fine in terms of VRam, but only 1GB of physical memory - quite a potato :)

// Loading entire speech archives into memory causes OOM on iPhone7
if(i.name.find(u"Speech")!=std::string::npos)
continue;
#endif
Expand Down
Loading