Skip to content

Load memory-mapped speech archives on iOS - #1008

Open
tryk016 wants to merge 1 commit into
Try:masterfrom
tryk016:codex/pr-opengothic-ios-speech-20261007
Open

tryk016 wants to merge 1 commit into
Try:masterfrom
tryk016:codex/pr-opengothic-ios-speech-20261007

Conversation

@tryk016

@tryk016 tryk016 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Stop skipping speech archives when ZenKit is built with memory mapping. This restores dialogue voices without copying the entire archives into memory.

Keep the existing skip for iOS builds without memory mapping.

Comment thread common/resources.cpp
try {
#ifdef __IOS__
// causes OOM on iPhone7
#if defined(__IOS__) && !defined(_ZK_WITH_MMAP)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ZK_WITH_MMAP is enabled by default, at least right now.
I need to get back to it and test again, if it works on iPhone7. It should be fine in terms of VRam, but only 1GB of physical memory - quite a potato :)

@Try

Try commented Oct 11, 2026

Copy link
Copy Markdown
Owner

I've tested it on my phone today - game crashes with EXC_BADACCESS. Maybe alternative can be to add runtime check: if device has 2GB+ ram only then map "speech"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants