Skip to content

fix(socks-proxy-agent): trim brackets from IPv6 literal proxy hosts #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajanpanth wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(socks-proxy-agent): trim brackets from IPv6 literal proxy hosts #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/socks-proxy-agent/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ const setServernameFromNonIpHost = <
function parseSocksURL(url: URL): { lookup: boolean; proxy: SocksProxy } {
let lookup = false;
let type: SocksProxy['type'] = 5;
const host = url.hostname;
// Trim off the brackets from IPv6 addresses
const host = url.hostname.replace(/^\[|\]$/g, '');

// From RFC 1928, Section 3: https://tools.ietf.org/html/rfc1928#section-3
// "The SOCKS service is conventionally located on TCP port 1080"
Expand Down
5 changes: 5 additions & 0 deletions packages/socks-proxy-agent/test/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ describe('SocksProxyAgent', () => {
assert.equal(socksServerUrl.hostname, agent.proxy.host);
assert.equal(+socksServerUrl.port, agent.proxy.port);
});
it('should trim brackets from an IPv6 literal proxy host', () => {
const agent = new SocksProxyAgent('socks5h://[::1]:1080');
assert.equal(agent.proxy.host, '::1');
assert.equal(agent.proxy.port, 1080);
});
it('should respect `timeout` option during connection to socks server', async () => {
const agent = new SocksProxyAgent(socksServerUrl, { timeout: 1 });

Expand Down