fix(socks-proxy-agent): trim brackets from IPv6 literal proxy hosts - #452
Open
rajanpanth wants to merge 1 commit into
Open
fix(socks-proxy-agent): trim brackets from IPv6 literal proxy hosts#452rajanpanth wants to merge 1 commit into
rajanpanth wants to merge 1 commit into
Conversation
WHATWG URL keeps the brackets in hostname for IPv6 literals, so socks://[::1]:1080 passed [::1] to the socks connection and failed with getaddrinfo ENOTFOUND. Mirrors the existing trim in https-proxy-agent. Fixes TooTallNate#437
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437.
WHATWG
URLkeeps the brackets inhostnamefor IPv6 literals (new URL('socks://[::1]:1080').hostname === '[::1]'), andparseSocksURLpassed that straight through as the proxy host, so the socks connection tried to resolve[::1]as a name and failed withgetaddrinfo ENOTFOUND [::1].The fix mirrors the trim this monorepo already does in
https-proxy-agent(same regex, same comment), so the two agents now treat IPv6 proxy URLs the same way:Non-bracketed hosts are untouched (
127.0.0.1, hostnames), and a changeset is not included since I do not know the release cadence you want; happy to add one.Test added asserting
socks5h://[::1]:1080producesproxy.host === '::1'. 13 passing; with the source change reverted, the new test fails.