Skip to content

fix: footer not positioned correctly in problem page #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiichi3227 merged 6 commits into from
Jul 5, 2026
+40 −6
Merged

fix: footer not positioned correctly in problem page #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22cee7d
fix: footer not positioned correctly in problem page
uyo9 Jul 2, 2026
2e7b309
fix(pro): remove fixed height and improve sidebar layout
uyo9 Jul 3, 2026
1b504bc
fix: remove an extra comma
uyo9 Jul 3, 2026
271c675
perf(pro): resize layout at most once per frame
uyo9 Jul 3, 2026
7a94324
fix(pro): reset sidebar height to auto
uyo9 Jul 5, 2026
3af26ec
fix(pro): remove resize event handler after page rerendering
uyo9 Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/static/templ/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
海に生き，海を守り，海を行く，それがブルーマーメード
-->

<body data-bs-theme="dark">
<body data-bs-theme="dark" class="d-flex flex-column min-vh-100">
<!-- style="background-color: #314783;" -->
<nav class="navbar navbar-expand-lg">
<div id="index-navlist" class="container-fluid">
Expand Down Expand Up @@ -240,10 +240,10 @@
</div>
</nav>

<div class="container-fluid" id="index-cont" style="min-height:100%;">
<div class="container-fluid flex-grow-1" id="index-cont">
</div>

<footer class="text-muted py-3 me-3 float-end">
<footer class="text-muted py-3 pe-3 text-end">
<small>New TNFSH Online Judge - Go-Judge</small>
</footer>

Expand Down
40 changes: 37 additions & 3 deletions src/static/templ/pro.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
html_url = `{{ url(f'/pro/{ pro.pro_id }/cont.html') }}`;
{% end %}

var onResize = null;

function init() {
let PDFJS = pdfjsLib;
PDFJS.GlobalWorkerOptions.workerSrc = 'https://cdnjs.cloudflare.com/ajax/libs/pdf.js/4.7.76/pdf.worker.min.mjs';
Expand Down Expand Up @@ -61,9 +63,32 @@
}
});

let resizeRaf = null;
onResize = function() {
if (viewer != 2 || resizeRaf)
return;

resizeRaf = requestAnimationFrame(function() {
resizeRaf = null;
_resize_pdf_embed_viewer();
});
};
$(window).on('resize', onResize);

let j_cont = $('#cont');
let j_side = $('#side');

function _resize_pdf_embed_viewer() {
let top = j_cont[0].getBoundingClientRect().top;
let footerH = $('footer').outerHeight(true) || 0;
let height = Math.max(200, window.innerHeight - top - footerH - 16);
j_cont.css('height', `${ height }px`);
j_side.css('height', `${ height }px`);
Comment thread
uyo9 marked this conversation as resolved.
}

function _load_html() {
j_cont.css('height', 'auto');
j_side.css('height', `auto`);
j_cont.load(html_url, function(res, status, xhr) {
if (status == 'error') {
$('#pdfbtn').show();
Expand All @@ -86,6 +111,8 @@
}

function _load_pdf_js() {
j_cont.css('height', 'auto');
j_side.css('height', `auto`);
PDFJS.getDocument(pdf_url).promise.then(function(pdf) {
j_cont.empty();
for (let i = 1; i <= pdf.numPages; i++) {
Expand Down Expand Up @@ -134,14 +161,22 @@

function _load_pdf_embed() {
j_cont.empty();
_resize_pdf_embed_viewer();
var embed = $(`<embed width="100%" height="100%" src="${pdf_url}" type="application/pdf">`);
j_cont.append(embed);
}
_load_html();
}

function destroy() {
if (onResize) {
$(window).off('resize', onResize);
onResize = null;
}
}
</script>
<div class="row">
<div id="side" class="col-lg-2 col-12 mt-lg-2">
<div id="side" class="col-lg-2 col-12 mt-lg-2" style="overflow-y: scroll;">
<h3>{{ pro.pro_id}} / {{ pro.name }}</h3>
{% if can_submit and pro.allow_submit %}
{% if contest and not contest.is_end() %}
Expand Down Expand Up @@ -265,8 +300,7 @@ <h5 class="card-title">Waiting for you to become the first <span class="state-1"
</div>
</div>

<!-- TODO: Remove fixed height -->
<div id="cont" class="col-lg-10 col-12" style="height: 904px;">
<div id="cont" class="col-lg-10 col-12">
<strong>Loading...</strong>
</div>
</div>
Loading