fix: footer not positioned correctly in problem page#268
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #92 where the footer on the problem page appears in an unexpected position (requiring a small scroll before it becomes visible), by removing fixed-height constraints and adjusting layout structure to better fit the viewport.
Changes:
- Removed the fixed inline height on the problem content container and reset container height to
autowhen loading HTML/PDF (PDF.js) content. - Updated the embedded-PDF viewer flow to explicitly set a content height (currently via
vh). - Converted the index layout to a flex-column, full-viewport-height structure so the main content grows to fill space and the footer naturally sits at the bottom.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/static/templ/pro.html | Removes fixed content height and adjusts container height behavior when loading problem statements (HTML/PDF). |
| src/static/templ/index.html | Switches base page layout to a flex column with min-vh-100 and a flex-grow-1 content region to stabilize footer placement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tobiichi3227
requested changes
Jul 5, 2026
Collaborator
|
Thank @uyo9 for contributing! 🎊 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#92