fix(types): make renderer typecheck clean#518
Closed
JustYannicc wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 3, 2026
Collaborator
Author
|
Superseded by #532 (fix(validation): restore project checks), which consolidates this validation/build change with the related source PRs. Closing this PR in favor of the upstream replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
liquid-glass-reactrenderer import so the renderer project can typecheck without a missing-module diagnostic.Why
Renderer performance PRs were inheriting existing repo-wide TypeScript noise. The baseline renderer project check failed with exit 2 and 46 diagnostics across 20 files, so unrelated work could not rely on a clean renderer typecheck signal.
Compatibility impact
No behavior removal intended. The changes align TypeScript declarations with existing runtime behavior and data shapes. User-facing strings were not added, renamed, or removed.
How tested
./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falseexited 2 with 46 diagnostics../node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty falseexited 0 with 0 diagnostics.src/renderer/srcscan plus targeted checks forraycast-api/index.tsx,hooks/useLauncherCommandModel.ts,settings/AITab.tsx, andutils/quicklink-icons.tsxreported no errors.pnpm testpassed: 24 pass, 1 skipped because live Electron is not launchable here.pnpm run build:rendererpassed.pnpm run check:i18nexited 0; it still reports pre-existing Italian locale missing keys forsettings.ai.whisper.vocabularyandsettings.extensions.appSearchScope.