perf(browser-search): index hot query path#520
Closed
JustYannicc wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Browser search was still scanning every history and bookmark entry for typed root queries even though an entry index existed. Large browser datasets could make each keystroke spend more than 100 ms in candidate generation.
Compatibility impact
Search result scoring, dedupe, completion, and ordering are preserved by verifying indexed candidates with the existing full scoring path. The code falls back to full scans when the query shape cannot be represented safely by the index. No user-facing strings or i18n keys changed.
How tested
node --test scripts/test-browser-search-lag-fix.mjs scripts/test-browser-search-performance.mjsnode --test 'scripts/test-*.mjs'./node_modules/.bin/tsc -p tsconfig.main.json./node_modules/.bin/vite buildnode scripts/check-i18n.mjssrc/renderer/src/hooks/useBrowserSearch.ts: no errors.Stack validation
This issue was found and validated from
codex/perf-integration-stack, which contains the current performance fix stack, including the renderer typecheck cleanup from #518. On that integrated branch,./node_modules/.bin/tsc -p tsconfig.renderer.json --noEmit --pretty false,./node_modules/.bin/tsc -p tsconfig.main.json --noEmit --pretty false, andnode --test 'scripts/test-*.mjs'pass.