Skip to content

fix(demo-rollup): fix assertions' inconsistencies #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YichiZhang0613 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(demo-rollup): fix assertions' inconsistencies #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/demo-rollup/sov-benchmarks/src/node/rollup_coarse_measure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ fn print_times(
table.printstd();

assert!(
tps > MIN_TPS,
tps >= MIN_TPS,
"TPS {tps} dropped below {MIN_TPS}, investigation is needed"
);
assert!(
tps < MAX_TPS,
"TPS {tps} reached unrealistic number {MAX_TPS}, investigation is needed"
tps <= MAX_TPS,
"TPS {tps} exceeded unrealistic number {MAX_TPS}, investigation is needed"
);
}

Expand Down
2 changes: 1 addition & 1 deletion examples/demo-rollup/tests/restart/graceful.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ async fn check_with_increasing_stf_infos(
.unwrap();
assert!(
slot.number > last_processed_slot_number,
"Received notification for slot n={} is lower than last seen: {}",
"Received notification for slot n={} is not greater than last seen: {}",
slot.number,
last_processed_slot_number
);
Expand Down
Loading