Skip to content

fix(demo-rollup): fix assertions' inconsistencies#2885

Open
YichiZhang0613 wants to merge 1 commit into
Sovereign-Labs:devfrom
YichiZhang0613:fix_inconsistency
Open

fix(demo-rollup): fix assertions' inconsistencies#2885
YichiZhang0613 wants to merge 1 commit into
Sovereign-Labs:devfrom
YichiZhang0613:fix_inconsistency

Conversation

@YichiZhang0613

@YichiZhang0613 YichiZhang0613 commented May 18, 2026

Copy link
Copy Markdown

Description

In rollup_coarse_measure.rs, the message indicates tps should be >= MIN_TPS(fail when "below") while the predicates require tps > MIN_TPS. According to const's definition(comments), it should be tps >= MIN_TPS. So the
assert!(tps < MAX_TPS, "TPS {tps} reached unrealistic number {MAX_TPS}, investigation is needed"); should also be changed.

In graceful.rs, the predicate requires slot.number > last_processed_slot_number while the message requires slot.number >= last_processed_slot_number(fail when "is lower than"). The message should be changed.

// Minimum TPS, below which it is considered an issue
const MIN_TPS: f64 = 1000.0;
// Number to check that rollup actually executed some transactions
const MAX_TPS: f64 = 30_000.0;
  • [] I have updated CHANGELOG.md with a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.
  • [] I have carefully reviewed all my Cargo.toml changes before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)

@YichiZhang0613 YichiZhang0613 changed the title fix(demo-rollup): fix assertions' inconsistency fix(demo-rollup): fix assertions' inconsistencies May 18, 2026
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@YichiZhang0613

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant