Skip to content

CMake: dont require mathjax #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nim65s wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

CMake: dont require mathjax #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b34904
CMake: dont require mathjax
nim65s Jun 29, 2026
db86317
add changelog entry
nim65s Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## [Unreleased]

### Removed

- CMake: remove unconditional `DOXYGEN_USE_MATHJAX`. You can turn it on if necessary with `cmake -DDOXYGEN_USE_MATHJAX=ON`. ([#467](https://github.com/Simple-Robotics/proxsuite/pull/467))

## [0.7.3] - 2026-05-11

### Added
Expand Down
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,13 @@ option(BUILD_DOCUMENTATION "Build the documentation." OFF)
option(BUILD_BENCHMARK "Build the benchmarks" OFF)
option(INSTALL_DOCUMENTATION "Install the documentation" OFF)
option(BUILD_PYTHON_INTERFACE "Build the Python bindings" OFF)
set(DOXYGEN_USE_MATHJAX YES)

@jorisv jorisv Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to turn it into an option like pinocchio ?

@nim65s nim65s Jul 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this break conda/pixi otherwise :(

option(PROXSUITE_DOXYGEN_USE_MATHJAX "Avoid latex at build time" ON)
set(DOXYGEN_USE_TEMPLATE_CSS YES)

if(PROXSUITE_DOXYGEN_USE_MATHJAX)
set(DOXYGEN_USE_MATHJAX YES)
endif()

# install() DESTINATION paths are normalized (to remove in 3.31) (copied over
# from Pinocchio)
if(POLICY CMP0177)
Expand Down
Loading