[Feat] Bind private integrations to private Sessions - #2640
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| integration?.description ?? | ||
| 'Use tools from this deployment-configured MCP server.', | ||
| instructions: integration?.instructions, | ||
| dataPolicy: getMcpIntegrationDataPolicy(integration), |
Contributor
There was a problem hiding this comment.
dataPolicy is computed here but is dropped when candidates are converted into the returned FastAgentIntegration objects at lines 595-609. Consequently a catalog-discovered private integration reaches the Fast service with dataPolicy === undefined, so the private-session filter, broker owner check, transcript redaction, and audit redaction all treat it as shared. Forward the policy in that return object and cover the discovery path; the current test only passes a manually constructed private integration directly to the broker.
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
shared | privateintegration data policy; all existing integrations remain shared.Why this change was made
Credential ownership and data confidentiality are separate; future private providers must opt into the Session boundary.
Impact
No existing integration is reclassified and no connector is added.
Related PRs