[Feat] Keep private Sessions out of shared memory - #2637
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| if (reasoningEffort === undefined) | ||
| reasoningEffort = session.reasoningEffort; | ||
| const availableIntegrations = selectFastRoomoteChannelTools({ | ||
| currentSessionPrivacy = session.privacy ?? 'shared'; |
Contributor
There was a problem hiding this comment.
This is the Fast conversation's privacy, not the parent sessions row. A Fast conversation attached to a private Session is inserted with its default shared privacy, and attachFastConversationToSession only sets the foreign key. That leaves the integration filtering/audit redaction disabled and lets save_memory enqueue content for a private Session. Propagate the parent Session privacy when binding, or resolve the bound Session's privacy here.
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
synthesizeand private query/result persistence; deny external shared-memory MCPs.Why this change was made
Every producer and drainer must reject private content so retries and explicit tools cannot copy it into shared memory.
Impact
Shared Brain behavior remains unchanged; private state is still dark in this stack step.
Related PRs