Skip to content

fix(footer): nojs min-height styles #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bennypowers merged 5 commits into from
Jul 29, 2025
Merged

fix(footer): nojs min-height styles #2541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e60e3e1
fix(footer): correct application of nojs min-height styles
zeroedin Jul 29, 2025
67bb839
chore(footer): add changeset
zeroedin Jul 29, 2025
49c94c2
chore: remove local dotfile
zeroedin Jul 29, 2025
4bc5e8d
style: lint
bennypowers Jul 29, 2025
1657305
Merge branch 'staging/diglett' into fix/footer/nojs-styles
bennypowers Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/yellow-mice-lose.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@rhds/elements": patch
---

`<rh-footer>`: corrected height style when javascript is not available'

9 changes: 7 additions & 2 deletions elements/rh-footer/rh-footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@
display: flex;
flex-direction: column;
color-scheme: only dark !important;
}

/** Minimum height for the footer when JavaScript is disabled */
min-height: var(--rh-footer-nojs-min-height, 750px);
/* Should only be applied if scripting is disabled */
@media (scripting: none) {
:host {
/** Minimum height for the footer when JavaScript is disabled */
min-height: var(--rh-footer-nojs-min-height, 750px);
}
}

:host,
Expand Down
4 changes: 2 additions & 2 deletions elements/rh-navigation-primary/rh-navigation-primary.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
@container navigation-primary (min-width: 576px) {
border-block-end-color: transparent;
}

& svg {
block-size: 30px;
inline-size: 42px;
Expand All @@ -81,7 +81,7 @@
block-size: 30px;
inline-size: 125px;
}
}
}

& ::slotted(a),
& a {
Expand Down