fix(footer): nojs min-height styles - #2541
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1657305 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: +31 B (+0.01%) Total Size: 234 kB
ℹ️ View Unchanged
|
Member
|
good catch, @zeroedin . could have been a bad merge. I'm happy to revert those lines |
bennypowers
approved these changes
Jul 29, 2025
markcaron
added a commit
that referenced
this pull request
Aug 6, 2025
* fix:(tag): improve color contrast of gray tags on dark color schemes (#2325) * fix(tag): improve color contrast on gray tags in dark schemes * docs(tag): improve slotted SVG color contrast on dark schemes * docs(tag): fix `grey` vs `gray` in alt text * chore(tag): add changeset * feat(breadcrumb): add truncation (#2357) * feat(breadcrumb): add ability to truncate middle breadcrumb items This code was developed with possible assistance by generative AI. * chore(breadcrumb): add changeset * fix(breadcrumb): only truncate when `truncate` attr is present This code was developed with possible assistance by generative AI. * test(breadcrumb): fix `handleEvent` uncaught TypeError This code was developed with possible assistance by generative AI. * docs(breadcrumb): update changeset prose Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * refactor(breadcrumb): rename truncate lightdom classes * refactor(breadcrumb): nest `[hidden]` under `rh-breadcrumb` selector * fix(breadcrumb): implement `render()` method for `truncate` functionality This code was developed with possible assistance by generative AI. * refactor: nest lightdom css * refactor: minor nitpicks * fix(breadcrumb): add `type` attr to truncate button * fix(breadcrumb): underline truncation button / ellipsis * fix(breadcrumb): use logical properties * lint(breadcrumb): css * test(breadcrumb): add tests for `truncate` This code was developed with possible assistance by generative AI. * test(breadcrumb): unify test examples * test(breadcrumb): add null guards --------- Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> Co-authored-by: Benny Powers <web@bennypowers.com> * feat(code-block): hide line numbers (#2319) * feat(code-block): add attribute/ability to hide line numbers * chore(code-block): add changeset * style(code-block): lint typescript and css * fix(code-block): change attr to `line-numbers` in place of `hide-line-numbers` * refactor(code-block): rename `lineNumbers` variable * chore(code-block): update changeset example * fix(code-block): prevent possible SSR mismatch errors * docs(code-block): add `line-numbers="hidden"` docs * fix(card): allow light(est/er) and dark(est/er) color palettes (#2329) * fix(card): allow all six color palettes on card * docs(card): allow all color palettes in nested color context demo * docs(card): add terminology clarifying color palette usage vs backgrounds * docs(card): use `darkest` color palette with Promo demo as docs instruct * chore(card): add changeset * style(card): lint css * fix(card): correct `color-palette` / card background behavior ("Option 3") * docs(card): color context prose * style(card): lint css * docs(card): move color palette docs to style page * fix(card): use `--rh-color-surface` for both `.light` and `.dark` * refactor(card): surface colors for card background when `color-palette` is set * refactor(card): move `computedPalette` to `willUpdate()` * refactor(card): move promo vars to render method * perf(code-block): avoid unnecessarily computing line numbers (#2415) * feat(code-block): reduce line numbers load * feat(code-block): adding return to computeLineNumbers * docs: changeset --------- Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * fix(code-block): fix failing build (#2421) * fix(code-block): fix syntax error breaking build * chore(code-block): add changeset * style: revert remove dom This is kind of a six-of-one scenario. is it better to remove DOM? or is it better to avoid thrashing the DOM when we add and remove on changes? In either case, I think It's more readable this way, even if there's an empty, aria-hidden dom node * chore: delete .changeset/shy-coins-fall.md --------- Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * feat(tag): add interactive states (#2407) * fix(tag): remove errant curly brace from demo * fix(tag): use logical properties * fix(tag): update interactive (link) tag styles * style(tag): alphabetize CSS selectors * fix(tag): make focus and active state include icon * feat(tag): add functionality for disabled linked tags * docs(tag): rename label 👉 tag in api docs * docs(tag): remove docs for `close` nonexistent event * docs(tag): rename demo to `links.html` * feat(tag): add ability to make a tag a `<button>` * feat(tag): FACE + click event for button tags * docs(tag): rename buttons demo * docs(tag): add changeset * docs(tag): update bi-modal `overview.svg` * docs(tag): update Style page * docs(tag): update guidelines page * docs(tag): update a11y page images * fix(tag): remove button variant See #2407 (comment) for more info. * fix(tag): allow clicks to pass through active state * fix(tag): keep `cursor: pointer;` for the active state on linked tags * docs(tag): remove button tag info from docs * fix(tag): remove button callback and event Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * chore(tag): update changeset * fix(tag): prevent disabled linked tags from navigating to a URL --------- Co-authored-by: marionnegp <mapatel@redhat.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * fix(footer): remove console warnings (#2468) * fix(footer): remove logger warnings, use ifDefined * chore(footer): add changeset * feat(navigation-primary): bimodal logo (#2463) * fix(navigation-primary): add bimodal svg, logo-url and logo-text-hide-at attributes * chore(navigation-primary): add changeset * docs(navigation-primary): add logo attributes demo * fix(navigation-primary): change name of logo-url to logo-href to closer match other apis * fix(navigation-primary): allow xs breakpoint * fix(navigation-primary): set default to xl for logo-text-hide-at * fix(accordion): remove accidental style commit * chore(navigation-primary): update changeset * fix(navigation-primary): remove configureable attribute for breakpoint of logo text * fix(navigation-primary): remove href property * docs: update changeset, demos --------- Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * feat: update inline link underline styles (#2418) * feat: remove underline from rh-breadcrumbs, remove link underline styles from avatar and table css * feat: add dashed underline style to skip link and pagination * feat: updated link styles for footer and tile * feat(pagination): update underline style for focus state * fix(breadcrumbs): fix after merge * fix(footer): fix order of css for footer links * fix(uxdot-feedback): use correct blues for link * fix(uxdot-feedback): fixed css line length * feat: add changeset * fix(breadcrumb): fix stylelint problem * feat(footer): update text decoration and transition properties * feat(pagination, skip link): fix transition and text-decoration thickness * feat: fix text decoration properties for tile and add variable fallback for footer, pagination, skip link * docs(links): update the example CSS for inline links' underlines * docs(avatar): update link styles in images * docs(avatar, breadcrumbs): update link style in images * fix(footer): replace broken token * feat(breadcrumb): add dashed underline to hover states * docs(avatar, breadcrumbs): replace images in docs * docs: update footer images and add .avif to 11ty's list of files * docs(pagination): update images * feat(skip link): update hover and active styles * fix(skip link): fix broken docs image * docs(table): update inline link styles in images * docs(pagination): update overview.svg * Update .changeset/red-parks-drop.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * docs(footer): document link font size in JS file --------- Co-authored-by: Adam Johnson <adjohnso@redhat.com> Co-authored-by: Adam Johnson <adam.b.johnson1@gmail.com> * chore(inline-links): change minor to patch changeset * test(cta): add regression tests for missing arrow icon (#2473) * chore(cta): add `PfeDemoPage.js` to `package.json` exports via `patch-package` * test(cta): add e2e tests for CTA icons, update existing tests to pass * chore: delete patches/@patternfly+pfe-tools+4.0.3.patch * fix(cta): remove optional chaining operator from element in e2e tests --------- Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * chore: revert line from merge * style: lint * fix(footer): nojs min-height styles (#2541) * fix(footer): correct application of nojs min-height styles * chore(footer): add changeset * chore: remove local dotfile * style: lint --------- Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * docs: add Patterns > Tag page (#2431) * docs(tag pattern): start drafting content for new patterns > tag page * fix: fix order of pattern pages and font size of code in alerts * docs(tag pattern): add images for interactive states * docs(tag pattern): add example * Change border-width of rh-tag pattern on hover Co-authored-by: Adam Johnson <adjohnso@redhat.com> * docs(tag pattern): fix indentation * docs(tag pattern): remove button without tag inside * docs: fix patterns' page order * docs(tag pattern): fix interactive state images and update focus style * docs(tag pattern): remove unnecessary imports Co-authored-by: Adam Johnson <adjohnso@redhat.com> * docs(tag pattern): remove line break in <uxdot-pattern> Co-authored-by: Adam Johnson <adjohnso@redhat.com> * docs(tag pattern): reformat to match other <style> tags in element docs Co-authored-by: Adam Johnson <adjohnso@redhat.com> --------- Co-authored-by: Adam Johnson <adjohnso@redhat.com> * docs: patch pfe-tools demo helpers * docs: passthrough global css from tokens to dev server cc @adamjohnson * feat(skeleton): add `<rh-skeleton>` (#2430) * feat(skeleton): add `<rh-skeleton>` * docs(skeleton): add prose to readme * docs(skeleton): move `overview.svg` to `/docs` * fix(skeleton): remove `aria-busy` Only to be used in live regions. * test(skeleton): add a11y tests * docs(skeleton): add content to Overview page * docs(skeleton): add content to Style page * docs(skeleton): add content to Guidelines page * docs(skeleton): update Accessibility page content * docs(skeleton): add `screenshot.png` for localhost previews * fix(skeleton): change `<p>` to `<span>` in shadowdom * fix(skeleton): update background gradient opacities * fix(skeleton): square skeleton default border radius * fix(skeleton): sizing of various `size`'s * docs(skeleton): update docs for bennypowers/cem * fix(skeleton): scope `size` attr to not apply to shape skeletons * docs(skeleton): update content * fix(skeleton): update skeleton types to include `heading`/`body-copy` + updated size tokens * docs(skeleton): update size info for shape skeletons * docs(skeleton): delete overview.svg --------- Co-authored-by: marionnegp <mapatel@redhat.com> Co-authored-by: Benny Powers <web@bennypowers.com> * feat(scheme-toggle): added `<rh-scheme-toggle>` (#2448) * initial commit for scheme-toggle, need to refactor css to use class attached to fieldset * added styes for ststem default * added the reset of the styles to add system default * refactored css to rely on theme tokens * chore(scheme-toggle): linting * fix(scheme-toggle): cleaning up unused code * fix(scheme-toggle): clean up commments and made css revisions * test(scheme-toggle): added tests * test:(rh-scheme-toggle) updated tests to use accessibility tree * fix(scheme-toggle): removed connected callback and firstUpdated, now handled with default settings * fix(scheme-togg): fixed linting errors * chore: removed color-palette attribute from web-dev-server Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * chore: adjusted tests so it statments are only related to outcomes * chore: added css fallbacks * fix(scheme-toggle): added server checks, added lifecyle firstUpdated * fix(scheme-toggle): corrected CSS styling for light and dark states * fix(scheme-toggle): Added recommended fallback values. Co-authored-by: Adam Johnson <adjohnso@redhat.com> * chore(scheme-toggle): added summary and description, refactored schemeCheck * fix(scheme-toggle): removed style that was breaking light mode * chore(scheme-toggle): added changeset * chore(scheme-toggl): fix verbiage Co-authored-by: Adam Johnson <adjohnso@redhat.com> * chore(scheme-toggle): update repostatus * chore(scheme-toggle): updated readme * Update elements/rh-scheme-toggle/rh-scheme-toggle.ts Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> * docs: inline docs * refactor: we little css refactor * fix(scheme-toggle): remove margin from fieldset, host display block * docs: implement rh-scheme-toggle * refactor: move state setup to connectedCallback * docs(scheme-toggle): draft docs These should be revised (cc @coreyvickery) shortly after release --------- Co-authored-by: Chase Gatyas <cgatyas@redhat.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> Co-authored-by: Adam Johnson <adjohnso@redhat.com> Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> * chore: changesets formatting, typos * feat(progress-stepper): add <rh-progress-stepper> element (#2449) * Progress Stepper Redux * Fix Lint Errors * Addressing feedback * feat(progress-step): adjusting active to inactive step-line-color * Update demos, slots, and styles * Address latest feedback * Pushing latest changes * Fix lint errors and status * docs(progress-stepper): inline docs * docs(progress-stepper): readme * feat(progress-stepper): CSS cleanup and vertical fixes * feat(progress-stepper): fixing thumbnail and adding themable to element * feat(progress-stepper): fixing demos to be simpler and adding color-context and label-attribute demos * docs(progress-stepper): tag aliases * feat(progress-stepper): adding new demos, improving API on compact, fixing linked labels, and more * docs(progress-stepper): update content on Overview page * docs(progress-stepper): remove outdated code.md page * docs(progress-stepper): update content on Style page * docs(progress-stepper): remove outdated images on Guidelines page * docs(progress-stepper): update content on Guidelines page. WIP. * docs(progress-stepper): add rwd and best practices to guidelines page * docs(progress-stepper): add a11y docs page and content * docs(progress-stepper): update content for all elements page * feat(progress-stepper): adding mobile support, cleaning up host styles * chore(progress-stepper): match changeset to RHDS new element formatting * test(progress-stepper): add some initial tests * style: whitespace * refactor: make current step a context * feat(progress-stepper): minor css grid adjustments to match designs more closely * fix(progress-stepper): output current step to shadowdom for non-compact variants * feat(progress-stepper): updates to JSDocs * docs(progress-stepper): Adding coming soon to interaction states section * Update elements/rh-progress-stepper/README.md Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-progress-stepper/rh-progress-stepper.css Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-progress-stepper/rh-progress-step.css Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-progress-stepper/rh-progress-step.css Co-authored-by: Adam Johnson <adjohnso@redhat.com> * Update elements/rh-progress-stepper/rh-progress-step.css Co-authored-by: Adam Johnson <adjohnso@redhat.com> * feat(progress-stepper): addressing 5 of 7 of Marionne' design feedback * style(progress-stepper): fix lint issue on --rh-color-status-disabled * fix(progress-stepper): spacing/grid issues per Marionne * test(progress-stepper): removing unused a11ySnapshot * docs: ssr progress stepper * docs(progress-stepper): update demos, jsdoc Prefer attributes to slots * perf(progress-stepper): recompute state as needed Also improves inline documentation * fix(progress-stepper): always treat icon as an active step Also, don't reflect default "inactive" state * docs: disable ssr for progress stepper * fix(progress-stepper): make custom icon font weight medium, like active state --------- Co-authored-by: Mark Caron <mark.caron@gmail.com> Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: Benny Powers - עם ישראל חי! <bennypowers@users.noreply.github.com> Co-authored-by: Adam Johnson <adam.b.johnson1@gmail.com> Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> Co-authored-by: Adam Johnson <adjohnso@redhat.com> * docs(release-notes): updating release notes for Diglett v3.1 (#2547) * docs(release-notes): updating release notes for Diglett v3.1 * fix(release-notes): alphabetizing highlights --------- Co-authored-by: Adam Johnson <adjohnso@redhat.com> Co-authored-by: Mark Caron <markcaron@users.noreply.github.com> Co-authored-by: marionnegp <mapatel@redhat.com> Co-authored-by: Steven Spriggs <steven.spriggs@gmail.com> Co-authored-by: Marionne Patel <95588923+marionnegp@users.noreply.github.com> Co-authored-by: Adam Johnson <adam.b.johnson1@gmail.com> Co-authored-by: Chase Gatyas <MagRat04@users.noreply.github.com> Co-authored-by: Chase Gatyas <cgatyas@redhat.com> Co-authored-by: Luke <ldary@redhat.com> Co-authored-by: Mark Caron <mark.caron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Testing Instructions
Notes to Reviewers
There is a bigger problem likely here where
rh-footer-universalloadsrh-footer.cssinstead of its own CSS file, so it also loads the same :host rule.On ux.redhat.com, we do not load the full footer, so we were incorrectly getting the 750px min-height set.
Because this value is also
nojs, it is now wrapped in ascripting: none. https://developer.mozilla.org/en-US/docs/Web/CSS/@media/scripting@bennypowers I noted that this rule was added in #2482 and wasn't caught in review. This isn't a new variable, as it already exists in the lightdom CSS. Could this potentially have been a mistake?