chore: adopt cem - #2455
Merged
Merged
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
there's an irreconcileable conflict between the old analyzer and the new one. so this is blocked on patternfly/patternfly-elements#2912 |
bennypowers
force-pushed
the
docs/cem-tool-update
branch
from
June 24, 2025 06:17
c778655 to
cd524a0
Compare
This was referenced Jun 26, 2025
bennypowers
marked this pull request as ready for review
July 16, 2025 11:39
Contributor
|
Size Change: +236 B (+0.1%) Total Size: 235 kB
ℹ️ View Unchanged
|
bennypowers
enabled auto-merge (squash)
July 16, 2025 12:22
adamjohnson
self-requested a review
July 16, 2025 14:26
adamjohnson
requested changes
Jul 16, 2025
adamjohnson
left a comment
adamjohnson
left a comment
Collaborator
There was a problem hiding this comment.
Getting return is not defined after running npm run dev and loading localhost:8000. 8000 doesn't load / is a white page in the browser.
Here's my terminal output: https://app.warp.dev/block/DD60n1cKaVvHaLzC8MOwnR
Member
Author
|
I think the test failures result from the upgraded playwright version |
Member
Author
|
Ok this is ready for review. Things to watch out for:
|
bennypowers
force-pushed
the
docs/cem-tool-update
branch
from
July 18, 2025 14:24
7a2ac0e to
f155c48
Compare
Merged
Collaborator
If you go to any component's Looks like the path Still reviewing, but I thought I would surface this. |
adamjohnson
previously requested changes
Jul 18, 2025
adamjohnson
left a comment
adamjohnson
left a comment
Collaborator
There was a problem hiding this comment.
Some more things I found:
- On each components Overview page in the docs, the knobs demo takes the first demo listed under the Demos page. This seems to never be the default
rh-{component}.htmldemo—rather, some variant. The Overview knobs demo should show each component's default demo. - On the Demos page (eg:
/elements/accordion/demos/), the default demo is never first. It should appear first in the list. - If I clone this PR and run it locally on the dev server, clicking the image for each demo does not include the trailing
/for the base demo's permalink. 👇
- Running this locally and hitting the correct base demo URL (eg:
localhost:8000/elements/accordion/demo/) does not show the accordion demo, but the All elements overview (same view aslocalhost:8000).- Hitting the other variants of a component does work
- When hitting localhost:8000, there is a link ("Accordion") in the first
<pf-card>and, instead of having the header say "Accordion", it says "Expanded Index".
- When hitting
localhost:8000, Jump Links and Tabs have duplicate links to their various demos. - When hitting
localhost:8000, not all Footer demos are listed under the Footer component.
Member
Author
|
ok @adamjohnson i think i addressed everything. we don't need to repeat overview demo on demos page |
bennypowers
changed the title
cem
bennypowers
dismissed
adamjohnson’s stale review
July 20, 2025 06:23
thanks for the review, i addressed all points, and am merging now to unblock other PRs. any remaining issues we'll take up elsewhere
bennypowers
disabled auto-merge
July 20, 2025 06:23
github-project-automation
Bot
moved this from Review 🔍
to Done ☑️
in Red Hat Design System
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
@custom-elements-manifest/analyzerwith@pwrs/cemmove part and slot docs into templateslet's do this separatelymove css prop docs into css fileslet's do this separately