[AMDGPU][COMGR] Add hotswap text displacement infrastructure#3000
Draft
harsh-amd wants to merge 10 commits into
Draft
[AMDGPU][COMGR] Add hotswap text displacement infrastructure#3000harsh-amd wants to merge 10 commits into
harsh-amd wants to merge 10 commits into
Conversation
This was referenced Jun 21, 2026
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
4905511 to
02c967b
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
02c967b to
fe6deae
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
fe6deae to
3c1d9b2
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
3c1d9b2 to
9eba7e5
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 21, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
de81d5f to
d037ab1
Compare
harsh-amd
added a commit
to harsh-amd/TheRock
that referenced
this pull request
Jun 22, 2026
ISSUE ID: ROCm/llvm-project#3000 Build on PR ROCm#6007 by pinning amd-llvm to a commit that includes the COMGR hotswap kernel-entry trampoline implementation and rocm-systems to the paired loader-side revert.
d037ab1 to
971b27d
Compare
This was referenced Jun 22, 2026
This was referenced Jun 22, 2026
971b27d to
6904b53
Compare
6904b53 to
15a9271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.textdirectly instead of using only appended trampolines.Stack
GitHub cannot use fork-only branches as ROCm PR bases, so this PR still targets
amd-staging. The layer-only diff isharsh-amd:comgr-hotswap-entry-trampolines...harsh-amd:hotswap-entry-trampolines.Testing
git diff --check comgr-hotswap-entry-trampolines..comgr-hotswap-displacementmake -j$(nproc) HotswapElfTests HotswapMCTests hotswap-rewriteinbuild-comgr-displacement-sharedbuild-comgr-displacement-shared/test-unit/HotswapElfTestsbuild-comgr-displacement-shared/test-unit/HotswapMCTestsmake -j$(nproc) test-litinbuild-comgr-displacement-shared(70 passed / 11 unsupported)