Skip to content

[rocr] Remove loader-side gfx125x entry trampolines#7592

Draft
harsh-amd wants to merge 16 commits into
ROCm:developfrom
harsh-amd:hotswap-rocr-loader-trampoline-removal
Draft

[rocr] Remove loader-side gfx125x entry trampolines#7592
harsh-amd wants to merge 16 commits into
ROCm:developfrom
harsh-amd:hotswap-rocr-loader-trampoline-removal

Conversation

@harsh-amd

@harsh-amd harsh-amd commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Stack

Layer 3 of the rocm-systems hotswap stack, paired with the COMGR hotswap stack after COMGR owns the rewrite machinery.

GitHub targets this PR at develop, so the default Files view includes prior stack layers. Use the layer-only diff above for review of this layer.

Summary

  • Remove the ROCr loader-owned gfx125x kernel-entry trampoline allocation, stub emission, descriptor fixups, and trampoline segment freezing added by Install Kernel Trampolines #7581.
  • Preserve the Install Kernel Trampolines #7581 gfx125x blit-kernel v_nop changes; this layer has no blit_shaders diff.
  • Drop the loader-owned kernel descriptor fixup state and helper declarations from ExecutableImpl.
  • Leave runtime request gating in libhsa-hotswap.so and binary rewriting in COMGR.

Paired PRs

Testing

  • git diff --check hotswap-entry-trampoline-gating...HEAD
  • rg -n "InstallTrampolines|trampoline_enabled|kd_fixups|trampoline_segments|BuildTrampoline|CodeObjectIsaIsGfx125|kTrampoline|kInstPrefUnitBytes" projects/rocr-runtime/runtime/hsa-runtime/loader/executable.cpp projects/rocr-runtime/runtime/hsa-runtime/loader/executable.hpp (no matches)
  • git diff --name-only hotswap-entry-trampoline-gating...HEAD -- projects/rocr-runtime/runtime/hsa-runtime/core/runtime/blit_shaders (no output)

@harsh-amd harsh-amd force-pushed the hotswap-rocr-loader-trampoline-removal branch from b2ed512 to f1ab65d Compare June 27, 2026 23:06
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
───
Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant