[rocr] Remove loader-side gfx125x entry trampolines#7592
Draft
harsh-amd wants to merge 16 commits into
Draft
Conversation
This was referenced Jun 22, 2026
fd16cb5 to
b2ed512
Compare
b2ed512 to
f1ab65d
Compare
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Layer 3 of the rocm-systems hotswap stack, paired with the COMGR hotswap stack after COMGR owns the rewrite machinery.
GitHub targets this PR at
develop, so the default Files view includes prior stack layers. Use the layer-only diff above for review of this layer.Summary
v_nopchanges; this layer has noblit_shadersdiff.ExecutableImpl.libhsa-hotswap.soand binary rewriting in COMGR.Paired PRs
Testing
git diff --check hotswap-entry-trampoline-gating...HEADrg -n "InstallTrampolines|trampoline_enabled|kd_fixups|trampoline_segments|BuildTrampoline|CodeObjectIsaIsGfx125|kTrampoline|kInstPrefUnitBytes" projects/rocr-runtime/runtime/hsa-runtime/loader/executable.cpp projects/rocr-runtime/runtime/hsa-runtime/loader/executable.hpp(no matches)git diff --name-only hotswap-entry-trampoline-gating...HEAD -- projects/rocr-runtime/runtime/hsa-runtime/core/runtime/blit_shaders(no output)