pulse: fix race condition whith allowing recording early - #177
Merged
Conversation
marmarek
force-pushed
the
early-rec-race
branch
from
August 6, 2026 02:22
9848420 to
73509e8
Compare
This was referenced Aug 6, 2026
Open
Open
Open
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026080611-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 30 fixed
Unstable testsDetails
Performance TestsPerformance degradation:19 performance degradations
Remaining performance tests:92 tests
|
Listening on qubesdb events is set early, it's possible the request to
allow recording will come before pulseaudio context is fully set. That
may lead to errors like this:
Connection to qube established, connecting to PulseAudio daemon
rec pa_stream_new() failed: Invalid argument
Fix this by manipulating recording stream only after pulseaudio is fully
set (use u->rec_stdio_event as a proxy for that info). If it isn't, only
save requested state, context_state_callback() will later connect the
stream.
And also, fix error handling in connect_disconnect_rec_stream_locked() -
return early in case of error, quit() function only schedules
termination, but it does return.
Fixes QubesOS/qubes-issues#11038
QubesOS/qubes-issues#
marmarek
force-pushed
the
early-rec-race
branch
from
August 7, 2026 00:11
1dadb6d to
95e379e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listening on qubesdb events is set early, it's possible the request to
allow recording will come before pulseaudio context is fully set. That
may lead to errors like this:
Fix this by manipulating recording stream only after pulseaudio is fully
set (use u->rec_stdio_event as a proxy for that info). If it isn't, only
save requested state, context_state_callback() will later connect the
stream.
And also, fix error handling in connect_disconnect_rec_stream_locked() -
return early in case of error, quit() function only schedules
termination, but it does return.