policy-daemon: invalidate cache on file move too#170
Merged
Conversation
Invalidate cache not only when file is modified inside policy dir, but also when it's moved in or out.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 78.01% 77.99% -0.03%
==========================================
Files 54 54
Lines 9637 9664 +27
==========================================
+ Hits 7518 7537 +19
- Misses 2119 2127 +8 ☔ View full report in Codecov by Sentry. |
Contributor
|
Looks geat, except there are no tests 🙂. |
DemiMarie
reviewed
Jun 27, 2024
DemiMarie
left a comment
DemiMarie
left a comment
Contributor
There was a problem hiding this comment.
One more test that could be added, but IIUC it won’t add new coverage.
Comment on lines
+129
to
+139
| # now move out | ||
| file_moved.rename(file) | ||
|
|
||
| await asyncio.sleep(1) | ||
|
|
||
| assert cache.outdated | ||
|
|
||
| cache.get_policy() | ||
|
|
||
| call = unittest.mock.call(policy_path=policy_path) | ||
| assert mock_parser.mock_calls == [call, call, call] |
Contributor
There was a problem hiding this comment.
What about moving within the directory?
Member
Author
There was a problem hiding this comment.
It's then both move from and move to, so this case is covered too.
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062721-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests11 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 5 fixed
Unstable testsDetails
|
This was referenced Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalidate cache not only when file is modified inside policy dir, but
also when it's moved in or out.