Skip to content

Mention filesystem fixes for 50-qubesbuilder.policy#109

Closed
aronowski wants to merge 1 commit into
QubesOS:mainfrom
aronowski:policy-instructions-fix
Closed

Mention filesystem fixes for 50-qubesbuilder.policy#109
aronowski wants to merge 1 commit into
QubesOS:mainfrom
aronowski:policy-instructions-fix

Conversation

@aronowski

Copy link
Copy Markdown

README.md had no information regarding the filesystem owner, group and permissions for the 50-qubesbuilder.policy file to be copied. Therefore, the procedure described resulted in the file being owned by user:user and having permission bits 644, what resulted in qrexec-policy-daemon being unable to find any matching rule, e.g.:

$ journalctl --follow -u qubes-qrexec-policy-daemon
[...]
May 02 03:52:42 dom0 qrexec-policy-daemon[1526]: qrexec: admin.vm.CreateDisposable: work-qubesos -> qubes-builder-dvm: denied: no matching rule found

This fix adds the mentions, how to adjust the filesystem properties, so the policy works as intended.

README.md had no information regarding the filesystem owner, group and
permissions for the 50-qubesbuilder.policy file to be copied. Therefore,
the procedure described resulted in the file being owned by `user:user`
and having permission bits `644`, what resulted in qrexec-policy-daemon
being unable to find any matching rule, e.g.:

```
$ journalctl --follow -u qubes-qrexec-policy-daemon
[...]
May 02 03:52:42 dom0 qrexec-policy-daemon[1526]: qrexec: admin.vm.CreateDisposable: work-qubesos -> qubes-builder-dvm: denied: no matching rule found
```

This fix adds the mentions, how to adjust the filesystem properties, so
the policy works as intended.

Signed-off-by: Kamil Aronowski <kamil.aronowski@yahoo.com>
@marmarek

marmarek commented May 2, 2024

Copy link
Copy Markdown
Member

the procedure described resulted in the file being owned by user:user and having permission bits 644,

This is okay

what resulted in qrexec-policy-daemon being unable to find any matching rule

qrexec-policy-daemon definitely can read such file. In fact, it's running as root, so it can read any file. The issue you hit must be somewhere else...

@codecov

codecov Bot commented May 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (9101f0a) to head (f0cdfa8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   77.20%   77.20%           
=======================================
  Files          46       46           
  Lines        5002     5002           
=======================================
  Hits         3862     3862           
  Misses       1140     1140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aronowski

aronowski commented May 2, 2024 via email

Copy link
Copy Markdown
Author

@marmarek

Copy link
Copy Markdown
Member

I'm pretty sure the issue you observe will be fixed with QubesOS/qubes-core-qrexec#170

@marmarek marmarek closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants