Skip to content

skyline: Fixed Visual Studio builds of Skyline.sln to use the ProteoWizard binaries matching the active configuration #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickshulman merged 3 commits into from
Sep 9, 2026
Merged

skyline: Fixed Visual Studio builds of Skyline.sln to use the ProteoWizard binaries matching the active configuration #4634

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561e409
Fix build in Visual Studio by adding pwiz projects to Skyline.sln
nickshulman Sep 1, 2026
f8c8f4f
Remove byte order marks
nickshulman Sep 3, 2026
afc2a15
Make sure to use Release external dll's with Release build in Visual …
nickshulman Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pwiz-sharp/pwiz/src/Vendor/Sciex/Reader_Sciex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Pwiz.Data.Common.Cv;
using Pwiz.Data.Common.Cv;
using Pwiz.Data.MsData;
using Pwiz.Data.MsData.Readers;
#if !NO_VENDOR_SUPPORT
Expand Down
2 changes: 1 addition & 1 deletion pwiz-sharp/pwiz/src/Vendor/Thermo/Reader_Thermo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Globalization;
using System.Globalization;
using Pwiz.Data.Common.Cv;
using Pwiz.Data.Common.Params;
using Pwiz.Data.MsData;
Expand Down
Loading