Skip to content

skyline: Fixed Visual Studio builds of Skyline.sln to use the ProteoWizard binaries matching the active configuration #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickshulman merged 3 commits into from
Sep 9, 2026
Merged

skyline: Fixed Visual Studio builds of Skyline.sln to use the ProteoWizard binaries matching the active configuration #4634

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561e409
Fix build in Visual Studio by adding pwiz projects to Skyline.sln
nickshulman Sep 1, 2026
f8c8f4f
Remove byte order marks
nickshulman Sep 3, 2026
afc2a15
Make sure to use Release external dll's with Release build in Visual …
nickshulman Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions pwiz_tools/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,41 @@
<Visible>false</Visible>
</Content>
</ItemGroup>

<!-- Project references that point OUTSIDE the solution being built (the pwiz-sharp
projects, SkylineProcessRunner) have no entry in the solution configuration, so
MSBuild's AssignProjectConfiguration leaves them unassigned and - because
ShouldUnsetParentConfigurationAndPlatform defaults to true inside Visual Studio and
in solution builds - strips Configuration and Platform from the reference. The
referenced project then answers with ITS OWN defaults: Debug, AnyCPU. A Release
build of Skyline.sln therefore resolves pwiz-sharp\...\bin\Debug\net10.0\*.dll:
it fails with CS0006 when no Debug build of pwiz-sharp exists, and silently links
the Debug binaries when one does (observed 2026-09-02: a VS Release build put the
267,776-byte Debug Pwiz.Data.MsData.dll next to Skyline-daily.exe while the
248,320-byte Release one sat unused). Give unassigned references the solution's
Configuration and AnyCPU - the platform build.bat builds pwiz-sharp with - so the
IDE uses the Debug or Release ProteoWizard binaries matching the configuration
chosen in the IDE.

The stripping repeats at every level: BlibBuild's reference to BiblioSpec, or
Thermo's to Vendor.Common, is just as absent from Skyline.sln, and pwiz-sharp does
not import this file. Fixing only the first level built BlibBuild as Release on top
of a Debug BiblioSpec, so msparserD.dll and the Debug MascotShim.dll landed in
BlibBuild's Release output and Skyline's msparser.dll copy failed (MSB3030). So
ShouldUnsetParentConfigurationAndPlatform=false rides along in SetPlatform: the
reference is invoked with that string as global properties, and global properties
flow down to the referenced project's own references, so the whole out-of-solution
subtree inherits Configuration and Platform the way a build.bat csproj build does.
Command-line csproj builds carry no solution configuration and are untouched. -->
<Target Name="AssignOutOfSolutionProjectReferenceConfiguration"
AfterTargets="AssignProjectConfiguration"
Condition="'$(CurrentSolutionConfigurationContents)' != ''">
<ItemGroup>
<ProjectReferenceWithConfiguration Condition="'%(ProjectReferenceWithConfiguration.SetConfiguration)' == ''">
<SetConfiguration>Configuration=$(Configuration)</SetConfiguration>
<SetPlatform>Platform=AnyCPU;ShouldUnsetParentConfigurationAndPlatform=false</SetPlatform>
<GlobalPropertiesToRemove />
</ProjectReferenceWithConfiguration>
</ItemGroup>
</Target>
</Project>
Loading