Skip to content

osprey: Pin LangVersion to 14, which the tree already requires #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maccoss wants to merge 1 commit into from
Closed

osprey: Pin LangVersion to 14, which the tree already requires #4594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pwiz_tools/Osprey/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,19 @@
* the .NET 8.0 target can still be built AnyCPU on other hosts
(e.g. Arm64 macOS/Linux) without touching any csproj. -->
<Platforms>AnyCPU;x64</Platforms>
<LangVersion>latest</LangVersion>
<!-- Osprey requires C# 14. Osprey.Scoring/PickLdaModel.cs calls
string[].SequenceEqual(string[]) with only "using System;" imported, which
binds to System.MemoryExtensions.SequenceEqual through the C# 14 implicit
span conversion in extension receiver position. Under C# 13 and earlier the
only candidate is System.Linq.Enumerable.SequenceEqual, which that file does
not import, so the build fails.
"latest" silently meant whatever the installed SDK happened to offer, so a
.NET 9 SDK build failed with CS1061 in unrelated source rather than saying
the language version was wrong. Naming the version turns an SDK mismatch
into "CS1617: Invalid option '14' for /langversion", which points at the
cause. Building Osprey therefore needs the .NET 10 SDK (VS 2026); bump this
deliberately rather than by way of an SDK upgrade. -->
<LangVersion>14</LangVersion>
<Nullable>disable</Nullable>
<ImplicitUsings>disable</ImplicitUsings>
<Company>University of Washington</Company>
Expand Down