Skip to content

Give stacked PRs master's validations in smartBuildTrigger #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chambm merged 1 commit into from
Aug 19, 2026
Merged

Give stacked PRs master's validations in smartBuildTrigger #4591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions scripts/misc/smartBuildTrigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,19 @@ def merge(dict1, *dicts):

# substitute "release" for specific skyline_##.# versions
base_branch = re.sub("(Skyline/)?skyline_.*", "release", base_branch)

# A stacked PR is based on a work branch rather than master, but it is ultimately headed for
# master and should get master's validations. Without this, base_branch matches none of
# possible_base_branches, so the promotion loop below never flattens any target group - every
# group in this config is nested under "master" (and sometimes "release") - and the trigger
# loop then skips them all as isBaseBranchDict. The result is a PR whose only check is this
# script reporting that it triggered nothing.
#
# Only target promotion is affected. The change list is still computed as base...FETCH_HEAD
# against the REAL base ref, so a stacked PR still sees only its own commits' files.
if base_branch.startswith("Skyline/work/"):
base_branch = "master"

print("Base branch: '%s'" % base_branch)

possible_base_branches = ["master", "release"]
Expand Down
Loading