-
Notifications
You must be signed in to change notification settings - Fork 413
feat(sdk): register Pi as a built-in ACP provider and pre-install pi-acp in agent-server Docker image #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -347,6 +347,10 @@ class ACPProviderInfo: | |
| ACPModelOption(id="gemini-2.5-flash", label="Gemini 2.5 Flash"), | ||
| ) | ||
|
|
||
| _PI_MODELS: tuple[ACPModelOption, ...] = ( | ||
| ACPModelOption(id="default", label="Default"), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why default here?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unlike Claude Code, Codex, or Gemini CLI, pi-acp manages model resolution internally or via environment configuration. |
||
| ) | ||
|
|
||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # Reserved file-content credential secrets for the built-in providers. | ||
|
|
@@ -393,6 +397,7 @@ class ACPProviderInfo: | |
| CLAUDE_AGENT_ACP_VERSION = "0.63.0" | ||
| CODEX_ACP_VERSION = "1.1.7" | ||
| GEMINI_CLI_VERSION = "0.46.0" | ||
| PI_ACP_VERSION = "0.0.33" | ||
|
Deep070203 marked this conversation as resolved.
Outdated
|
||
|
|
||
|
|
||
| ACP_PROVIDERS: Mapping[str, ACPProviderInfo] = MappingProxyType( | ||
|
|
@@ -480,6 +485,26 @@ class ACPProviderInfo: | |
| # ``~/.gemini`` (ignoring XDG), so only HOME relocates its state. | ||
| data_dir_env_var="HOME", | ||
| ), | ||
| "pi": ACPProviderInfo( | ||
| key="pi", | ||
| display_name="Pi", | ||
| default_command=( | ||
| "npx", | ||
| "-y", | ||
| f"pi-acp@{PI_ACP_VERSION}", | ||
| ), | ||
| api_key_env_var=None, | ||
| base_url_env_var=None, | ||
| default_session_mode="default", | ||
|
Deep070203 marked this conversation as resolved.
Outdated
|
||
| agent_name_patterns=("pi-acp", "pi"), | ||
|
Deep070203 marked this conversation as resolved.
Outdated
|
||
| supports_set_session_model=True, | ||
| supports_runtime_model_switch=True, | ||
| session_meta_key=None, | ||
| available_models=_PI_MODELS, | ||
| default_model="default", | ||
| binary_name="pi-acp", | ||
| data_dir_env_var="PI_CODING_AGENT_DIR", | ||
| ), | ||
| } | ||
| ) | ||
| """Read-only registry of built-in ACP providers keyed by ``acp_server`` value.""" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.