feat(sdk): register Pi as a built-in ACP provider and pre-install pi-acp in agent-server Docker image - #4419
Open
Deep070203 wants to merge 2 commits into
Open
feat(sdk): register Pi as a built-in ACP provider and pre-install pi-acp in agent-server Docker image#4419Deep070203 wants to merge 2 commits into
Deep070203 wants to merge 2 commits into
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
Author
|
@VascoSch92 can you take a look and test and let me know if everything is working correctly. |
VascoSch92
self-requested a review
August 7, 2026 19:55
This was referenced Aug 8, 2026
VascoSch92
reviewed
Aug 10, 2026
| ) | ||
|
|
||
| _PI_MODELS: tuple[ACPModelOption, ...] = ( | ||
| ACPModelOption(id="default", label="Default"), |
Author
There was a problem hiding this comment.
Unlike Claude Code, Codex, or Gemini CLI, pi-acp manages model resolution internally or via environment configuration.
Setting id="default" with default_model="default" allows the SDK to pass a clean, non-null model option while letting pi-acp use its native default engine setup
VascoSch92
reviewed
Aug 10, 2026
VascoSch92
left a comment
Member
There was a problem hiding this comment.
left some comments. Perhaps look on what other ACP are doing.
Thanks :-)
This was referenced Aug 11, 2026
Author
|
@VascoSch92 resolved the comments. Check and let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
Resolves OpenHands/OpenHands#16204 by adding first-class upstream support for the Pi ACP coding agent in the SDK provider registry (
ACP_PROVIDERS) and pre-installingpi-acpin theopenhands-agent-serverbase Docker image.This allows Pi to be selected as a native ACP server discriminator (
acp_server: "pi"), matching the behavior ofclaude-code,codex, andgemini-cli.AGENT:
Why
Per review on OpenHands PR #16229 and issue OpenHands/OpenHands#16204, pi should not rely on frontend-only custom command spoofing or docker-mode hacks in agent-canvas. Instead, pi needs first-class upstream support in software-agent-sdk (alongside claude-code, codex, and gemini-cli) so that downstream clients and agent-server Docker containers get native Pi ACP support automatically.
Summary
Issue Number
OpenHands/OpenHands (#16204)
How to Test
Video/Screenshots
Type
Notes
Requires a bump in @openhands/typescript-client once released to expose "pi" to agent-canvas.