Skip to content

[16.0][ADD] base_tier_validation_review_history - #1311

Open
smorita7749 wants to merge 1 commit into
OCA:16.0from
qrtl:6878-add-base_tier_validation_review_history
Open

[16.0][ADD] base_tier_validation_review_history#1311
smorita7749 wants to merge 1 commit into
OCA:16.0from
qrtl:6878-add-base_tier_validation_review_history

Conversation

@smorita7749

@smorita7749 smorita7749 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Originally, on reset/restart, tier reviews were removed with unlink(), so the reject/approve trail was lost after a re-request cycle.
This improvement allows completed (approved/rejected) reviews to be archived (active=False) instead of deleted, preserving history.

Archived reviews are shown as a read-only "Reviews History" list on the record, and a new "Tier Reviews" menu lists reviews (current + history) across records, with a clickable link to each source document.

Configuration

Whether history is kept is resolved from two levels:

  • CompanySettings > Tier Validation > Keep Tier Review History (boolean): default for all tier definitions of the company.
  • Tier DefinitionKeep Tier Review History (selection: Keep / Do Not Keep / empty): overrides the company default in either direction; empty inherits the company setting.

Depends on #1307

@qrtl QT6878

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:16.0 mod:base_tier_validation Module base_tier_validation mod:base_tier_validation_review_history Module base_tier_validation_review_history labels Jul 14, 2026
@smorita7749 smorita7749 changed the title [ADD] base_tier_validation_review_history [16.0][ADD] base_tier_validation_review_history Jul 14, 2026
@smorita7749
smorita7749 force-pushed the 6878-add-base_tier_validation_review_history branch 2 times, most recently from 91b5b9a to 09047c2 Compare July 14, 2026 09:00
@OCA-git-bot OCA-git-bot removed the mod:base_tier_validation Module base_tier_validation label Jul 14, 2026

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial Review.

Comment thread base_tier_validation_review_history/models/tier_review.py Outdated
Comment thread base_tier_validation_review_history/models/tier_validation.py Outdated
@AungKoKoLin1997
AungKoKoLin1997 force-pushed the 6878-add-base_tier_validation_review_history branch from 55dd67d to 9963629 Compare July 28, 2026 03:39
@AungKoKoLin1997

Copy link
Copy Markdown
Contributor

@smorita7749 Please review my last commit and squash the commit after you confirm.

@OCA-git-bot OCA-git-bot added the mod:base_tier_validation Module base_tier_validation label Jul 28, 2026
@smorita7749
smorita7749 force-pushed the 6878-add-base_tier_validation_review_history branch from 9963629 to 1c898d6 Compare August 3, 2026 07:50
@OCA-git-bot OCA-git-bot removed the mod:base_tier_validation Module base_tier_validation label Aug 3, 2026
@smorita7749

Copy link
Copy Markdown
Contributor Author

@smorita7749 Please review my last commit and squash the commit after you confirm.

Thank you for your changes!
It seems good!

Keep completed tier reviews as history instead of deleting them once
the validation cycle ends. Archiving is resolved from a company-level
default and a per-tier-definition override (keep / do not keep /
inherit). Archived reviews are shown on the document and in a dedicated
Tier Reviews menu.
@smorita7749
smorita7749 force-pushed the 6878-add-base_tier_validation_review_history branch from 1c898d6 to a340d69 Compare August 5, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:base_tier_validation_review_history Module base_tier_validation_review_history series:16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants