[16.0][IMP] base_tier_validation: extract _remove_reviews hook - #1307
Open
smorita7749 wants to merge 1 commit into
Open
[16.0][IMP] base_tier_validation: extract _remove_reviews hook#1307smorita7749 wants to merge 1 commit into
smorita7749 wants to merge 1 commit into
Conversation
smorita7749
force-pushed
the
6878-imp-base_tier_validation
branch
from
July 2, 2026 03:41
9a5a0d2 to
8cb56e2
Compare
smorita7749
marked this pull request as ready for review
July 2, 2026 03:41
OCA-git-bot
added
series:16.0
mod:base_tier_validation
Contributor
|
Hi @LoisRForgeFlow, |
smorita7749
force-pushed
the
6878-imp-base_tier_validation
branch
from
July 3, 2026 01:31
8cb56e2 to
004dc43
Compare
yostashiro
suggested changes
Jul 11, 2026
smorita7749
force-pushed
the
6878-imp-base_tier_validation
branch
2 times, most recently
from
July 14, 2026 09:25
d494940 to
e3fccd2
Compare
smorita7749
changed the title
Extract the review removal in write()/restart_validation() into a _remove_reviews() method so other modules can change what happens to completed reviews (e.g. archive them as history instead of deleting).
smorita7749
force-pushed
the
6878-imp-base_tier_validation
branch
from
July 19, 2026 14:03
e3fccd2 to
19a0b64
Compare
AungKoKoLin1997
approved these changes
Jul 27, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the review removal in
write()/restart_validation()into a_remove_reviews()method, so other modules can override it to do something other than delete the reviews (e.g. archive them as history).@qrtl QT6878