Skip to content

font-manager: fix build issue - #557155

Merged
romildo merged 1 commit into
NixOS:masterfrom
ShowhyT:pkgs/font-manager
Aug 31, 2026
Merged

font-manager: fix build issue#557155
romildo merged 1 commit into
NixOS:masterfrom
ShowhyT:pkgs/font-manager

Conversation

@ShowhyT

@ShowhyT ShowhyT commented Aug 27, 2026

Copy link
Copy Markdown
Member

Closes: #557142

Fix build issue with newer vala versions via a patch. Fetched the patch from this PR:
FontManager/font-manager#468

Things done

@nixpkgs-ci
nixpkgs-ci Bot requested a review from romildo August 27, 2026 20:31
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 27, 2026
@ShowhyT
ShowhyT force-pushed the pkgs/font-manager branch 2 times, most recently from 960976c to 4b9be75 Compare August 27, 2026 20:38
@ShowhyT

This comment was marked as outdated.

Comment thread pkgs/by-name/fo/font-manager/package.nix Outdated
@ShowhyT
ShowhyT force-pushed the pkgs/font-manager branch 2 times, most recently from af2d582 to 6cf9465 Compare August 28, 2026 09:20
@ShowhyT

ShowhyT commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result for #557155

Generated using nixpkgs-review-gha (85088ce)

Command: nixpkgs-review pr 557155
Commit: 6cf9465b65ee6e9a9015394a932d142f88cb72b9 (subsequent changes)
Merge: 7f0b54b06c88be659c5c45db27d8f24582c07f2d

Logs: https://github.com/ShowhyT/nixpkgs-review-gha/actions/runs/33158996470/attempts/1

Download packages from cache:
  • x86_64-linux
    nix-store -r \
      --option binary-caches 'https://cache.nixos.org/ https://builds.cachix.org' \
      --option trusted-public-keys '
        cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
        builds.cachix.org-1:628RFN/JZH6b09pwud65gIAvYg9oGIEGIqNPy8cDRU4=
      ' \
      /nix/store/088270ibmrxkjxrkzsjg9w759g59s7sn-font-manager-0.9.4
  • aarch64-linux
    nix-store -r \
      --option binary-caches 'https://cache.nixos.org/ https://builds.cachix.org' \
      --option trusted-public-keys '
        cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
        builds.cachix.org-1:628RFN/JZH6b09pwud65gIAvYg9oGIEGIqNPy8cDRU4=
      ' \
      /nix/store/18blf7ih1wimyn7i7gay05jv93j0x8jn-font-manager-0.9.4

x86_64-linux

✅ 1 package built:
  • font-manager

aarch64-linux

✅ 1 package built:
  • font-manager

@romildo romildo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thunze thunze left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Verified that the package builds on x86_64-linux
  • Verified basic functionality of the package on x86_64-linux

Thanks!

@amarshall

Copy link
Copy Markdown
Member

Duplicate of #556842

@amarshall amarshall marked this as a duplicate of #556842 Aug 28, 2026
Comment thread pkgs/by-name/fo/font-manager/package.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Aug 28, 2026
@ShowhyT
ShowhyT force-pushed the pkgs/font-manager branch from 6cf9465 to 460cb81 Compare August 28, 2026 14:13
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Aug 28, 2026
Comment thread pkgs/by-name/fo/font-manager/package.nix Outdated
@ShowhyT
ShowhyT force-pushed the pkgs/font-manager branch from a1a8858 to 0658f7b Compare August 28, 2026 16:13
@romildo
romildo added this pull request to the merge queue Aug 31, 2026
Merged via the queue into NixOS:master with commit 2787c8b Aug 31, 2026
26 checks passed
@thunze thunze mentioned this pull request Aug 31, 2026
13 tasks
@ShowhyT ShowhyT added the backport release-26.05 Backport PR automatically label Aug 31, 2026
@nixpkgs-ci

nixpkgs-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-26.05:

@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-26.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: font-manager

5 participants